-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove lockfiles #79
Conversation
66a4bbc
to
05a558d
Compare
with: | ||
useLockFile: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kentcdodds If you want, I can remove these again in remix.init
But I think it would be best to keep this as bahmutov/npm-install
doesn't seem to support pnpm
https://github.com/bahmutov/npm-install#use-lock-file
Once bahmutov/npm-install#133 is implemented, I think we could reconsider this.
Any idea for what we should do about this? https://github.com/remix-run/indie-stack/runs/6358741070?check_suite_focus=true |
@kentcdodds Probably a good idea to remove |
I don't think we want to remove it from the Dockerfile because users will want it in there. |
@kentcdodds Then we should do an install first. We can't know what file people will have though, as we don't know which package manager they will use. remix-run/remix#3076 will already pass the used one to |
Yeah, let's be a little more sophisticated 👍 I just merged that PR. Thanks! |
We'll need to wait for the next release to make it happen though. 😕 |
Follow-up of remix-run/remix#3110