chore(Dockerfile): conditionally copy package manager lockfile #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcansh
force-pushed
the
mcansh-patch-1
branch
2 times, most recently
from
c8a23b0
to
8ce6113
Compare
mcansh
changed the title
| ADD package-lock.jso[n] yarn.loc[k] pnpm-lock.yam[l] pnpm-lock.ym[l] .pnpmfile.cj[s] ./ | ||
| # the following script will install the dependencies with which ever lock file is available | ||
| ADD scripts/install-deps.sh ./install-deps.sh | ||
| RUN ./install-deps.sh |
There was a problem hiding this comment.
Since we have packageManager available in remix.init, shouldn't we just update remix.init to install dependencies & replace the npm references with the correct calls?
There was a problem hiding this comment.
maybe? i'm not completely sold on that
There was a problem hiding this comment.
This way we keep all the packageManager related things in remix.init & the user of the stack doesn't need to know about it.
There was a problem hiding this comment.
I agree. Let's have remix.init handle this at project generation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the stack doesn't come with a package-lock.json since #67 causing docker builds to fail, but the file will exist after
create-remix