Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lockfile #2

Merged
merged 1 commit into from
May 18, 2022
Merged

chore: remove lockfile #2

merged 1 commit into from
May 18, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

For more info, see remix-run/remix#3110.

You should probably also implement something similar in remix.init for only ignoring these files in the repo but not when the project is created like we did in remix-run/indie-stack#79, remix-run/blues-stack#67 & remix-run/grunge-stack#53.

@nullndr
Copy link
Owner

nullndr commented May 18, 2022

Thank you so much

@nullndr nullndr merged commit 4e5204a into nullndr:main May 18, 2022
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch May 18, 2022 13:29
@nullndr nullndr mentioned this pull request May 19, 2022
@MichaelDeBoey
Copy link
Contributor Author

@nullndr Seems like this got reverted in fcb0592 🙈

@nullndr
Copy link
Owner

nullndr commented May 19, 2022

@MichaelDeBoey yeah, my bad, gonna fix this right now

@nullndr
Copy link
Owner

nullndr commented May 19, 2022

Deleted with 8f38c17.

@MichaelDeBoey again, thank you so much for the check.

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 19, 2022

Probably a good idea to ignore lockfiles in .gitignore in the root of the project & override it in remix.init (like I explained before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants