Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates): ignore lockfiles #3110

Merged
merged 1 commit into from
May 9, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented May 6, 2022

Just like in examples, we don't want to have lockfiles in templates either.

We're running npm/yarn/pnpm install in our CLI (both when creating & on init), so this could cause unnecessary lockfiles if the user's package manager is different from the one we included the lockfile for.

execSync(`${packageManager} install`, {
stdio: "inherit",
cwd: projectDir,
});

execSync(`${packageManager} install`, {
stdio: "ignore",
cwd: initScriptDir,
});

@MichaelDeBoey
Copy link
Member Author

I also updated our default stacks for this: remix-run/indie-stack#79, remix-run/blues-stack#67 & remix-run/grunge-stack#53

@kentcdodds kentcdodds merged commit 20b74b5 into remix-run:main May 9, 2022
@MichaelDeBoey MichaelDeBoey deleted the no-lockfiles-in-templates branch May 9, 2022 20:09
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 12, 2022
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 15, 2022
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 16, 2022
nullndr added a commit to nullndr/matador that referenced this pull request May 19, 2022
nullndr added a commit to nullndr/matador that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants