-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(templates): ignore lockfiles #3110
Merged
kentcdodds
merged 1 commit into
remix-run:main
from
MichaelDeBoey:no-lockfiles-in-templates
May 9, 2022
Merged
chore(templates): ignore lockfiles #3110
kentcdodds
merged 1 commit into
remix-run:main
from
MichaelDeBoey:no-lockfiles-in-templates
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2022
I also updated our default stacks for this: remix-run/indie-stack#79, remix-run/blues-stack#67 & remix-run/grunge-stack#53 |
MichaelDeBoey
force-pushed
the
no-lockfiles-in-templates
branch
from
May 6, 2022 17:26
77e7ea4
to
07506ce
Compare
MichaelDeBoey
force-pushed
the
no-lockfiles-in-templates
branch
from
May 9, 2022 12:57
07506ce
to
0f3dbbc
Compare
kentcdodds
approved these changes
May 9, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 10, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 12, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 15, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 16, 2022
This was referenced May 17, 2022
This was referenced May 17, 2022
nullndr
added a commit
to nullndr/matador
that referenced
this pull request
May 19, 2022
nullndr
added a commit
to nullndr/matador
that referenced
this pull request
May 19, 2022
This was referenced May 19, 2022
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in
examples
, we don't want to have lockfiles intemplates
either.We're running
npm/yarn/pnpm install
in our CLI (both when creating & oninit
), so this could cause unnecessary lockfiles if the user's package manager is different from the one we included the lockfile for.remix/packages/remix-dev/cli/create.ts
Lines 225 to 228 in a511d34
remix/packages/remix-dev/cli/commands.ts
Lines 71 to 74 in a511d34