-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identification of two variant miracle texts on the Miracle of St Mary and the monk Isaac #1249
base: master
Are you sure you want to change the base?
Conversation
Added elements on the Miracle of Mary and Isaac
5001-6000/LIT5673AkkonuColl.xml
Outdated
significant thematic differences, exist. To avoid confusion and overlap, the | ||
miracle has been subdivided into two distinct variants. </note> | ||
|
||
<div type="textpart" xml:id="AkkMir6A" corresp="LIT3592MiracleA"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that if you change the xml:id here you have to make sure that in manuscripts or other records where you may have referred to LIT5673AkkonuColl#AkkMir6
will have to be updated to point to LIT5673AkkonuColl#AkkMir6A
or LIT5673AkkonuColl#AkkMir6B
, respectively. To avoid possible errors it is best to keep AkkMir6
for the first version and only add AkkMir6B
or even have AkkMir6 for a non further identifiable miracle of Yeshaq, when one is not sure which one is included, and add AkkMir6A and AkkMir6B for the specific stories.
Even more importantly - concerning LIT3592Miracle
, you cannot simply rename CAe IDs or have two works associated with the same number (3592 = one number = one ID).
So you either, as above, use 3592 for the first version and create a NEW CAe ID for the second version, or keep LIT3592Miracle for the generic AkkMir6 (miracle of Yeshaq, any of the two, when one does not know which) and create TWO NEW CAe IDs for the two specific miracles.
5001-6000/LIT5673AkkonuColl.xml
Outdated
|
||
<div type="textpart" xml:id="AkkMir6A" corresp="LIT3592MiracleA"> | ||
<label>The Revelation of the Virgin Mary to the Devoted Monk Yǝsḥaq</label> | ||
<note> Yǝsḥaq, a monk under Bishop Gabriel of Alexandria, prayed for seven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these notes should be removed here and become abstracts under respective work records LIT3592Miracle for the first miracle and the new ID for the second one
I believe you have not quite understood the suggestion above.
|
this branch must contain the whole set of records |
Dear Guesh please do NOT create new records in the application betamasaheft. Just collect all in one branch WITHOUT using the application, offline, on your computer. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have collected all records here now, please work only in this branch, thank you
@@ -5,18 +5,21 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?><TEI | |||
<fileDesc> | |||
<titleStmt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I moved the file from #1329 to have a clear overview of the changes I will insert here the correct comments by @CarstenHoffmannMarburg too, please add him as a reviewer
3001-4000/LIT3592Miracle.xml
Outdated
@@ -5,18 +5,21 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?><TEI | |||
<fileDesc> | |||
<titleStmt> | |||
<title xml:id="t1" xml:lang="en">Miracle of Mary: Miracle of the monk Isaac</title> | |||
<title xml:id="t2" xml:lang="en">Miracle of the monk Yǝsḥāq</title> | |||
<title xml:id="t3" xml:lang="en">The monk, Yǝsḥaq, who prayed for seven years that St Mary would appear to him</title> | |||
<title xml:id="t2" xml:lang="en">Miracle of Mary: Miracle of the priest Isaac</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t1 and t2 are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to have (General record) in the title
3001-4000/LIT3592Miracle.xml
Outdated
@@ -33,7 +36,16 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?><TEI | |||
</encodingDesc> | |||
<profileDesc> | |||
<abstract> | |||
<p/> | |||
<p>A miracle conflation appears in various manuscripts, linked to this generic miracle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarstenHoffmannMarburg notes correctly
I suggest a modification of this abstract. You should 1) give a brief summary of the content and 2) inform the reader about the two existing versions and refer to them, 3) make clear, that this CAe is a general record and meant only for those attestations for which the exact version is not clear.
3001-4000/LIT3592Miracle.xml
Outdated
ወሀሎ፡ አሐዱ፡ መነኮስ፡ ኄር፡ ዘስሙ፡ ይስሐቅ፡ ወያፈቅራ፡ ለእግዝእትነ፡ ማርያም፡ | ||
ወእምንእሱ፡ ነበረ፡ በአሐቲ፡ ደብር፡ በመዋዕሊሁ፡ ለአባ፡ ገብርኤል። | ||
</ab> | ||
<note>This incipit, related to the first miracle version is taken from <ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarstenHoffmannMarburg notes correctly
I think, these incipits should go the newly created CAe to which they belong. If this is a generic record, it should not contain any incipit or explicit or any other text. Otherwise the encoders and users will be confused about the correct CAe.
3001-4000/LIT3592Miracle.xml
Outdated
</div> | ||
<div type="textpart" subtype="incipit" xml:lang="gez"> | ||
<note>This incipit , related to the second miracle version is taken from <ref | ||
type="mss" corresp="EMML 6938, f. 43v"/>.</note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the corresp
may contain ONLY the file name or an xml:id
, not text with blanks (when you move the incipit to the right place)
</teiHeader> | ||
<text> | ||
<body> | ||
<div type="bibliography"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need at least incipit for disambiguation - here and not under 3592
|
||
<body> | ||
<div type="bibliography"> | ||
<listRelation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need at least incipit for disambiguation - here and not under 3592
new/LIT7151Miracle.xml
Outdated
<desc> | ||
<ref type="mss" corresp="Tanasee102">Tanasee102, f. 70v</ref> | ||
</desc> | ||
</relation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need hasAttestation relations but you MUST have relations to show the connections between the different texts
3001-4000/LIT3592Miracle.xml
Outdated
<ref type="mss" corresp="EMML7543">EMML 7543, f. 27r</ref> | ||
</desc> | ||
</relation> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you MUST have relations to the versions
3001-4000/LIT3592Miracle.xml
Outdated
<title xml:id="t2" xml:lang="en">Miracle of the monk Yǝsḥāq</title> | ||
<title xml:id="t3" xml:lang="en">The monk, Yǝsḥaq, who prayed for seven years that St Mary would appear to him</title> | ||
<title xml:id="t2" xml:lang="en">Miracle of Mary: Miracle of the priest Isaac</title> | ||
<title xml:id="t3" xml:lang="en">The monk, Yǝsḥaq, who prayed for seven years that St |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that t3 and t4 have nothing to do with this GENERAL RECORD at all, as it is a generic ID to be used for ANY miracle of Yeshaq when one does not know which one exactly
@@ -209,12 +211,13 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?> | |||
</div> | |||
|
|||
<div type="textpart" xml:id="AkkColl6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you must have the div as it was, with id AkkColl6 and corresp 3592
and then two nested div to the variant miracles with corresp to new IDs
5001-6000/LIT5673AkkonuColl.xml
Outdated
<label>Miracle</label> | ||
<label>Miracle of the monk Yǝsḥaq</label> | ||
<div type="textpart" xml:id="AkkMir6A" corresp="LIT3592Miracle"> | ||
<label>The Revelation of the Virgin Mary to the Devoted Monk Yǝsḥaq</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the labels should be the same as the main titles of the respective miracles
new/LIT7151Miracle.xml
Outdated
</relation> | ||
<relation name="lawd:hasAttestation" active="LIT7151Miracle" passive="BLorient639"> | ||
<desc> | ||
<ref type="mss" corresp="BLorient639">BLorient639, f. 57v</ref> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this witness cannot be in the same list with all the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the witnesses for the second miracle version (not for the first version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guesh, once again:
- The general record - it only has the GENERAL TITLE (not the titles of the versions) and the GENERAL ABSTRACT, it has no text, but it has RELATIONS to the versions
- The records for the versions have list of witnesses under listWit and specific titles and texts.
- Links (whether as
ref
,target
,corresp
,active
orpassive
) may have only IDs, there may be no blank spaces, brackets, or anything else between the quotation marks
Please revise all the records in this pull request very carefully. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all the records here are fine, you must revise all relevant manuscript records to point to the correct ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You now must
- in your github desktop switch to the branch 16-10-24-Isac
- open all XML files in question
- edit them according to the remarks and push so that we can review them again
Dear Guesh, please read carefully the instructions above and adjust the records.
|
3001-4000/LIT3592Miracle.xml
Outdated
<ref type="mss" corresp="EMML7543">EMML 7543, f. 27r</ref> | ||
</desc> | ||
</relation> | ||
<relation name="saws:hasPart" active="LIT3592Miracle" passive="LIT7150Miracle"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not parts but versions
3001-4000/LIT3592Miracle.xml
Outdated
@@ -33,7 +31,16 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?><TEI | |||
</encodingDesc> | |||
<profileDesc> | |||
<abstract> | |||
<p/> | |||
<p>A miracle conflation appears in various manuscripts, linked to this generic miracle | |||
theme. To clarify, two CAe IDs have been established. The first mircale version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should rephrase the summary to be generic and to point to the two versions through ref
.
5001-6000/LIT5673AkkonuColl.xml
Outdated
<div type="textpart" xml:id="AkkMir6A" corresp="LIT3592Miracle"> | ||
<label>The Revelation of the Virgin Mary to the Devoted Monk Yǝsḥaq</label> | ||
</div> | ||
<div type="textpart" xml:id="AkkMir6B" corresp="LIT3592Miracle"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you must restore the reference to AkkMir6 corresponding to LIT3592 as it used to be, revert your changes as already remarked
new/LIT7150Miracle.xml
Outdated
<teiHeader> | ||
<fileDesc> | ||
<titleStmt> | ||
<title xml:lang="gez" xml:id="t1">The Revelation of the Virgin Mary to the Devoted Monk Yǝsḥaq</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en
<abstract> | ||
<p> | ||
Yǝsḥaq, a devoted monk under Bishop Gabriel of Alexandria, dedicated himself | ||
to fervent nightly prayers before the Virgin Mary's icon for seven years, bowing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider the remarks
<profileDesc> | ||
<creation/> | ||
<abstract> | ||
<p> Yǝsḥaq, a devoted priest and abbot, celebrated the Marian feast each year with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
<teiHeader> | ||
<fileDesc> | ||
<titleStmt> | ||
<title xml:lang="gez" xml:id="t1">Financial hardships of the devoted priest Isaac during his celebration of Marian feasts</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en
new/LIT7151Miracle.xml
Outdated
<div type="bibliography"> | ||
<listRelation> | ||
<relation name="saws:formsPartOf" active="LIT7151Miracle" passive="LIT2384Taamme"/> | ||
<relation name="lawd:hasAttestation" active="LIT7151Miracle" passive="AkkMir6B" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
new/LIT7151Miracle.xml
Outdated
</div> | ||
<div type="edition"> | ||
<div type="textpart" subtype="incipit" xml:lang="gez"> | ||
<note>This incipit , related to the second miracle version is taken from <ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to specify the "second miracle version" as this record is for this one version only
new/LIT7150Miracle.xml
Outdated
</div> | ||
<div type="edition"> | ||
<div type="textpart" subtype="incipit" xml:lang="gez"> | ||
<note>This incipit, related to the first miracle version is taken from <ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to say "first miracle version" as this record is only for one version already
</div> | ||
<div type="textpart" xml:id="AkkMir6B" corresp="LIT3592Miracle"> | ||
<label> Financial hardships of the devoted priest Isaac during his celebration of Marian feasts</label> | ||
<div type="textpart" xml:id="AkkMir6" corresp="LIT3592Miracle"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this must be in line 213
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with A and B nested under the main div
</listRelation> | ||
<listWit xml:id="all"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listWit does not need xml:id and must go into sourceDesc above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless you refer to the xml:id of manuscripts in the list you do not need any of the xml:id assigned in the list below, please remove
</listRelation> | ||
<listWit xml:id="all"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above, no xml:id in listWit or in witness
<body> | ||
<div type="bibliography"> | ||
<listRelation> | ||
<relation name="saws:formsPartOf" active="LIT7150Miracle" passive="LIT2384Taamme"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not done
</div> | ||
<div type="edition"> | ||
<div type="textpart" subtype="incipit" xml:lang="gez"> | ||
<note>This incipit , related to the second miracle version is taken from <ref | ||
type="mss" corresp="EMML 6938, f. 43v"/>.</note> | ||
<note> <ref type="mss" corresp="EMML 6938, f. 43v"/> </note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can only have the id without any spaces as the value of corresp
Added elements on the Miracle of Mary and Isaac BetaMasaheft/Documentation#2613