Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications on the generic miracle record 3592 ( Miracle of Mary: St Mary and Isaac) #1329

Closed
wants to merge 2 commits into from

Conversation

GueshSol
Copy link
Contributor

@GueshSol GueshSol commented Nov 28, 2024

Following my discussion with @eu-genia I believe it is essential to create two CAe IDs for the generic miracle record, LIT3592Miracle. This record is linked to several manuscripts, making it difficult to modify. Therefore, I propose to leave the generic record (only modified the realtions and added note in the abstract on the differences) and create two CAe IDs that correspond to it, each providing the specific manuscript attestations for the two related but distinct miracles. I will provide the newly created CAe IDs soon. In the meantime, I would appreciate your thoughts on modifying this generic work record.

@CarstenHoffmannMarburg
Copy link
Contributor

If I understand you correctly, you want to keep one generic record (LIT3592Miracle) and you want to create two new LIT ID for those attestations, that you can describe more precisely. This is a good idea.

<xi:fallback>
<p>Definitions of prefixes used.</p>
</xi:fallback>
</xi:include>
</encodingDesc>
<profileDesc>
<abstract>
<p/>
<p> A miracle conflation appears in various manuscripts, linked to this generic miracle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a modification of this abstract. You should 1) give a brief summary of the content and 2) inform the reader about the two existing versions and refer to them, 3) make clear, that this CAe is a general record and meant only for those attestations for which the exact version is not clear.

ወሀሎ፡ አሐዱ፡ መነኮስ፡ ኄር፡ ዘስሙ፡ ይስሐቅ፡ ወያፈቅራ፡ ለእግዝእትነ፡ ማርያም፡
ወእምንእሱ፡ ነበረ፡ በአሐቲ፡ ደብር፡ በመዋዕሊሁ፡ ለአባ፡ ገብርኤል።
</ab>
<note>This incipit, related to the first miracle version is taken from <ref
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, these incipits should go the newly created CAe to which they belong. If this is a generic record, it should not contain any incipit or explicit or any other text. Otherwise the encoders and users will be confused about the correct CAe.

@eu-genia
Copy link
Contributor

It would be much nicer to keep all records together in the same branch #1249 as the changes are interconnected and all refer to the same issue. It is very difficult to jump between branches and pull requests for one thing

@eu-genia
Copy link
Contributor

Can you move the changes proposed here to the branch #1249 and have all in one pull request? then I would close this one

@eu-genia eu-genia closed this Nov 30, 2024
@eu-genia eu-genia deleted the 28-11-24-Isaac-G branch November 30, 2024 18:44
@GueshSol GueshSol restored the 28-11-24-Isaac-G branch December 11, 2024 12:44
@eu-genia eu-genia deleted the 28-11-24-Isaac-G branch January 16, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants