CodeCleaning

Code Cleaning

Cleaning

1. Build separate settings files:

• settings.yaml
• scenarios.yaml: scen definition, (maybe not much else yet)
• policy.yaml
• hazards.yaml (everything on hazards and hazards policy)

2. Subdivide data directory

• /data (i.e., still at the top level): README.md,
• /data/baseyear: baseyear_taz_controls.csv, county_forecast_inputs.csv, deed_restricted_zone_totals.csv, juris_controls.csv (used for overrride, may drop), taz_forecast_inputs.csv, taz2_foreacast_inputs.csv
• /data/accessibility: all AccessibilityMarkets files, all mandatoryAccessibility files, all nonMandatoryAccessibiity files, logsums.csv(is this still in use?)
• /data/hazards: parcel_tract_xwalk.csv, all slr files, tract_damage_earthquale.csv
• /data/policies: all zoning_mods files, vmt_fee_zonecats.csv, abag_targets.csv, rhna_by_juris.csv
• /data/control_totals/: all employment_controls files, all household_controls files, all regional_controls files, all regional_demographic_forecast files, county_employment_forecast.csv, zone_forecast_inputs.csv, maz_forecast_inputs.csv

3. Scenarios

• Remove scenario settings from model logic
• Remove scenario numbers from model logic (variables okay)

4. Clean up development projects csv/xls

• Assess duplicate projects (verify how they're treated)
• Return to varied scenarios once bug is fixed
• Fill in missing data ie "city"
• Create multiple files, or make source of project clear within single file

5. Overlapping code - clean or document

• sqft per employee
• developer profit margin/cap rate
• household relocation rates (and maybe employee?)

To Edit

• (preprocessing) Modify building type look up (https://github.com/BayAreaMetro/bayarea_urbansim/blob/54a797b3a23e50bb656998f85b59a0fec1bad0a6/baus/preprocessing.py#L308) so it take detailed two letter codes and turns them into simple two letter codes. Use the lookup table at https://github.com/BayAreaMetro/petrale/blob/master/incoming/dv_buildings_det_type_lu.csv . Incoming codes will be detailed_building_type in first column and want to change to last column "old" for consistency

To Drop (or move to snippets folder in /scripts)

• (preprocessing) move_jobs_from_portola_to_san_mateo_county
• (preprocessing) household_building_id_overrides.csv ???

To Zero Out

• (preprocessing) correct_base_year_vacancies: want this to do nothing but may be need later (https://github.com/BayAreaMetro/bayarea_urbansim/blob/54a797b3a23e50bb656998f85b59a0fec1bad0a6/baus/preprocessing.py#L182)

To Add

• (preprocessing) Note the suggested tests maybe Clint could do these? https://github.com/BayAreaMetro/bayarea_urbansim/blob/54a797b3a23e50bb656998f85b59a0fec1bad0a6/baus/preprocessing.py#L354

Keep Eye on While Updating Baseyear

• (preprocessing) extra four households added (https://github.com/BayAreaMetro/bayarea_urbansim/blob/54a797b3a23e50bb656998f85b59a0fec1bad0a6/baus/preprocessing.py#L131)