Handling modal windows #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have one modal and change the content in it.
kkosiorowska
force-pushed
the
handling-modal-window
branch
from
62ae591
to
bb9bb62
Compare
Actually, the ModalFlowContext should not know specific steps and should only return the current index.
|
This PR has been updated. Previously, each modal was opened separately. Currently, the modal is one and we only replace the content in it. |
r-czajkowski
requested changes
Dec 14, 2023
kkosiorowska
force-pushed
the
handling-modal-window
branch
from
d9cb254
to
94c2e9c
Compare
r-czajkowski
requested changes
Dec 19, 2023
| openSideBar() | ||
| } else { | ||
| closeSidebar() | ||
| timeout = setTimeout(resetState, 100) |
There was a problem hiding this comment.
Why do we need to reset state in timeout?
There was a problem hiding this comment.
After closing the modal, we should reset the active step state. However, if we do this without timeout we will see the default state in the modal for one moment. See the video below.
Screen.Recording.2023-12-19.at.16.25.28.mov
- use the `aside` tag - delete unnecessary DocsDrawer component
r-czajkowski
approved these changes
Dec 20, 2023
kkosiorowska
commented
Dec 20, 2023
| openSideBar() | ||
| } else { | ||
| closeSidebar() | ||
| timeout = setTimeout(resetState, 100) |
There was a problem hiding this comment.
After closing the modal, we should reset the active step state. However, if we do this without timeout we will see the default state in the modal for one moment. See the video below.
Screen.Recording.2023-12-19.at.16.25.28.mov
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inits the stake/ustake flow by handling modal windows. After opening the modal, the sidebar should also be visible. From the sidebar user can also open the docs drawer. This PR adds these components and sets the correct property
z-indexfor elements. The stake and unstake action require several modal windows to be opened in sequence. Let's manage this state with the context. A minor note, let's use context at this point and if we decide to use redux add it in a separate PR.Screen.Recording.2023-12-14.at.13.02.57.mov