Fix issues for eslint

thesis · Dec 14, 2023 · 62ae591 · 62ae591
1 parent 567d04a
commit 62ae591
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/dapp/src/components/Overview/PositionDetails.tsx b/dapp/src/components/Overview/PositionDetails.tsx
@@ -36,7 +36,9 @@ export default function PositionDetails(props: CardProps) {
       </CardBody>
       <CardFooter flexDirection="column" gap={2}>
         {/* TODO: Handle click actions */}
-        <Button size="lg" onClick={() => setIsOpenStakingModal(true)}>Stake</Button>
+        <Button size="lg" onClick={() => setIsOpenStakingModal(true)}>
+          Stake
+        </Button>
         <Button size="lg" variant="outline">
           Unstake
         </Button>

diff --git a/dapp/src/components/shared/ModalBase/index.tsx b/dapp/src/components/shared/ModalBase/index.tsx
@@ -14,6 +14,7 @@ export default function ModalBase({
   isOpen: boolean
   onClose: () => void
   steps: string[]
+  // eslint-disable-next-line react/require-default-props
   defaultIndex?: number
   children: React.ReactNode
 }) {
@@ -30,6 +31,11 @@ export default function ModalBase({
     onClose()
   }, [onClose])
 
+  const resetState = useCallback(() => {
+    setActiveStep(steps[defaultIndex])
+    setIndex(defaultIndex)
+  }, [defaultIndex, steps])
+
   useEffect(() => {
     if (index >= steps.length) {
       handleClose()
@@ -39,18 +45,16 @@ export default function ModalBase({
   }, [steps, index, handleClose])
 
   useEffect(() => {
-    if (!isOpen) {
-      closeSidebar()
+    let timeout: NodeJS.Timeout
 
-      const timeout = setTimeout(() => {
-        setActiveStep(steps[defaultIndex])
-        setIndex(defaultIndex)
-      }, 100)
-      return () => clearTimeout(timeout)
-    } else {
+    if (isOpen) {
       openSideBar()
+    } else {
+      closeSidebar()
+      timeout = setTimeout(() => resetState, 100)
     }
-  }, [isOpen, steps, defaultIndex, closeSidebar, openSideBar])
+    return () => clearTimeout(timeout)
+  }, [isOpen, resetState, openSideBar, closeSidebar])
 
   const contextValue: ModalFlowContextValue = useMemo<ModalFlowContextValue>(
     () => ({