Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render modal on the top of the components tree #87

Closed
Tracked by #154
kkosiorowska opened this issue Dec 20, 2023 · 1 comment
Closed
Tracked by #154

Render modal on the top of the components tree #87

kkosiorowska opened this issue Dec 20, 2023 · 1 comment
Labels
🎨 dapp dApp

Comments

@kkosiorowska
Copy link
Contributor

Modal is a global component and should be rendered on the top of the components tree. It shouldn't be rendered from the PositionDetails level.

Originally posted by @r-czajkowski in #70 (comment)
@kkosiorowska kkosiorowska mentioned this issue Dec 20, 2023
Closed
@r-czajkowski r-czajkowski mentioned this issue Dec 20, 2023
Merged
@nkuba nkuba mentioned this issue Jan 15, 2024
Open
@kkosiorowska
Copy link
Contributor Author

Done in #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 dapp dApp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkosiorowska