Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling modal windows #70
Handling modal windows #70
Changes from 16 commits
bdd3623
7cd3446
e32f154
4be5fce
9f2e4c1
8cbb73b
0892776
1d4e834
dcac86c
567d04a
bb9bb62
7ee5708
4ebb61a
6b6b3ef
5868aab
45bd3a7
f74104e
eebd8a6
94c2e9c
ba3298b
0d3e971
e57f802
81d7de5
8c5fd08
6f6be13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment.
Let's remove this comment after the merge #74. This rule is disabled there.
acre/dapp/.eslintrc
Lines 10 to 18 in 4d01503
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to reset state in timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After closing the modal, we should reset the active step state. However, if we do this without timeout we will see the default state in the modal for one moment. See the video below.
Screen.Recording.2023-12-19.at.16.25.28.mov