Fixed an issue about connecting wallets #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tally-ho-test-claim ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
force-pushed
the
web3-onboard-patch
branch
from
cbf341f to
8ad36a7
Compare
When Taho isn't the default wallet and MetaMask is installed we are unable to connect to the dapp. Let's force a connection to the Taho wallet and make sure the user receives the correct message when Taho isn't installed.
kkosiorowska
force-pushed
the
web3-onboard-patch
branch
from
8ad36a7 to
ffa8023
Compare
ioay
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #381
What
There is a issue related to incorrect handling of the Taho wallet in the
@web3-onboard/taholibrary. Let's fix this with a patch file. The solution is still not ideal because it does not catch the change of which wallet is switched on. This means that when we install the Taho wallet we have to refresh the page to see that the wallet has been installed. I think this solution is enough at the moment. Let's solve this problem in #423.Testing
When MetaMask is installed
When MetaMask is'n installed
When Taho isn't installed but MetaMask it is