Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently have to reload the dapp to get the wallet connected #416

Closed
andreachapman opened this issue Oct 17, 2023 · 3 comments
Closed
Assignees
Labels
🐛 bug Something isn't working

Comments

@andreachapman
Copy link
Contributor

On this build: https://github.com/tahowallet/tally-extension-token/pull/267
and https://tally-ho-test-claim.netlify.app/

I've cleared cache and loaded the dapp fresh. When I click connect wallet, nothing happens. I then refresh the browser (without doing anything in the wallet) and click connect wallet again and I can connect as expected.

In this instance, the account had connected to the site previously but this also happens if you disconnect from within the extension and then floow the same steps to load the dapp - the extension doesn't pop up to Sign until after you refresh.

refreshbrowser.mov
@michalinacienciala
Copy link
Contributor

@kkosiorowska , is the behavior described by Andrea a result of #422? Or it's something different?

@kkosiorowska
Copy link
Contributor

@kkosiorowska , is the behavior described by Andrea a result of #422? Or it's something different?

@michalinacienciala This isn't the result of #422 because the changes we are talking about were merged this morning. This is another problem that also occurs in 422.

@kkosiorowska kkosiorowska self-assigned this Oct 20, 2023
@kkosiorowska
Copy link
Contributor

I've looked into it. I don't quite sure whether we can do anything about it without refreshing the website. The problem is that when our detectEthereumProvider finds the window.ethereum object, it doesn't have information about the new wallet installed. The update will only be obtained when a page reload is performed. I checked that our detectEthereumProvider works the same way as for MM. Let's close this task for now and maybe come back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants