Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect wallet without Taho extension installed #381

Closed
andreachapman opened this issue Oct 16, 2023 · 6 comments · Fixed by #422
Closed

Connect wallet without Taho extension installed #381

andreachapman opened this issue Oct 16, 2023 · 6 comments · Fixed by #422
Assignees
@kkosiorowska
Labels
🐛 bug Something isn't working
Milestone
⛓️ Integration

Comments

@andreachapman
Copy link
Contributor

There are wallet connect scenarios that aren't working as we'd like.

When I have MetaMask installed but not Taho, if I click Connect wallet, I see an error:

Screen.Recording.2023-10-16.at.9.57.57.AM.mov

I think ideally, we'd like to do that same as this scenario below:

When I don't have Taho or MetaMask wallet installed, if I click Connect Wallet from the portal landing page, it redirects me to the Chrome store to install Taho

Screen.Recording.2023-10-16.at.9.57.30.AM.mov

I'm not sure that either really matters for beta since you shouldn't really know about this unless you have a Taho wallet. But, this is something we saw in a meeting earlier while we were looking at the beta site and we wanted to log it.
@andreachapman andreachapman added the 🐛 bug Something isn't working label Oct 16, 2023
@andreachapman andreachapman mentioned this issue Oct 16, 2023
Closed
@jagodarybacka jagodarybacka self-assigned this Oct 16, 2023
@michalinacienciala michalinacienciala mentioned this issue Oct 16, 2023
Closed
@michalinacienciala
Copy link
Contributor

Pasting @Shadowfiend's comment from a duplicated #388 issue here:

Let's address this one at a higher priority than other stuff @jagodarybacka .

Let's start by replacing “Connect wallet” with “Download Taho” in “Connect wallet to reach the portal”, and replace the button with a “Download Taho” link to the Chrome store. Then let's see if Vlad has bandwidth to adjust/improve.

@michalinacienciala
Copy link
Contributor

Let's start by replacing “Connect wallet” with “Download Taho” in “Connect wallet to reach the portal”

@Shadowfiend , should we show that “Download Taho” for all users, even those who already have Taho installed? Or only those without it?

@Shadowfiend
Copy link
Contributor

Shadowfiend commented Oct 17, 2023 •
edited
Loading

That should specifically be for users who don't have Taho installed (this should be pretty easy to detect, window.ethereum.providers.some((provider) => provider.isTaho) or so).

EDIT to say: just saw that we already make Connect wallet redirect to the Chrome store if no wallet is installed—hooking into that if there are wallets installed but none of them is Taho is also fine tbh, but then maybe we should say “Connect Taho”? Let's hook into the existing functionality though and then can discuss in product whether we want to tweak.

@michalinacienciala michalinacienciala mentioned this issue Oct 17, 2023
Closed
@michalinacienciala
Copy link
Contributor

just saw that we already make Connect wallet redirect to the Chrome store if no wallet is installed

I think that this redirect does not always work - it didn't work for me yesterday (see #389). Jagoda told me that whether the Chrome Store is opened or not is decided by an external component. So I think it would be good to have somewhere on the page a link to Taho extension app.

@jagodarybacka
Copy link
Contributor

ugh, I missed comments from this issue in the gh notifications 😬 will take a look at that first thing tomorrow

@kkosiorowska kkosiorowska mentioned this issue Oct 18, 2023
Merged
5 tasks
ioay added a commit that referenced this issue Oct 19, 2023
@ioay
Fixed an issue about connecting wallets (#422)
312a6f4 
Closes # #381


### What

There is a issue related to incorrect handling of the Taho wallet in the
`@web3-onboard/taho` library. Let's fix this with a patch file. The
solution is still not ideal because it does not catch the change of
which wallet is switched on. This means that when we install the Taho
wallet we have to refresh the page to see that the wallet has been
installed. I think this solution is enough at the moment. Let's solve
this problem in #423.


### Testing

**When MetaMask is installed**

- [ ]  Try connecting when the wallet is the default
- [ ]  Try connecting when the wallet is not the default

**When MetaMask is'n installed**

- [ ] Try connecting when the wallet is the default
- [ ] Try connecting when the wallet is not the default

**When Taho isn't installed but MetaMask it is**

- [ ] There is no connection possible. The user receives the correct
message.
@kkosiorowska
Copy link
Contributor

Done in #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkosiorowska kkosiorowska

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
⛓️ Integration
Development

Successfully merging a pull request may close this issue.

Fixed an issue about connecting wallets tahowallet/dapp
5 participants
@Shadowfiend @jagodarybacka @kkosiorowska @michalinacienciala @andreachapman