Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check out if it is possible to catch that the Taho has been installed without refreshing the page #423

Open
Tracked by #819
kkosiorowska opened this issue Oct 18, 2023 · 1 comment
Open
Tracked by #819

Check out if it is possible to catch that the Taho has been installed without refreshing the page #423

kkosiorowska opened this issue Oct 18, 2023 · 1 comment
Assignees
@jagodarybacka

Comments

@kkosiorowska
Copy link
Contributor

More information here.
@kkosiorowska kkosiorowska mentioned this issue Oct 18, 2023
Merged
5 tasks
ioay added a commit that referenced this issue Oct 19, 2023
@ioay
Fixed an issue about connecting wallets (#422)
312a6f4 
Closes # #381


### What

There is a issue related to incorrect handling of the Taho wallet in the
`@web3-onboard/taho` library. Let's fix this with a patch file. The
solution is still not ideal because it does not catch the change of
which wallet is switched on. This means that when we install the Taho
wallet we have to refresh the page to see that the wallet has been
installed. I think this solution is enough at the moment. Let's solve
this problem in #423.


### Testing

**When MetaMask is installed**

- [ ]  Try connecting when the wallet is the default
- [ ]  Try connecting when the wallet is not the default

**When MetaMask is'n installed**

- [ ] Try connecting when the wallet is the default
- [ ] Try connecting when the wallet is not the default

**When Taho isn't installed but MetaMask it is**

- [ ] There is no connection possible. The user receives the correct
message.
@jagodarybacka
Copy link
Contributor

Let's investigate a bit and close unless that's a quick fix

@jagodarybacka jagodarybacka mentioned this issue Dec 1, 2023
Open
@jagodarybacka jagodarybacka self-assigned this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagodarybacka jagodarybacka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jagodarybacka @kkosiorowska