Address the tasks in the Meta section #5105

anikiki · 2024-10-08T11:00:44Z

Task/Issue URL: https://app.asana.com/0/72649045549333/1208287265878043/f

Description

Added feature flag for switch to tab. Removed unneeded quick insert icons. Formatted urls in autosuggest. Added dividers between autosuggest sections.
Updated color on switch to tab icon.

Steps to test this PR

Feature 1

Install from this branch.
Open a few tabs.
Search for something that matches the open tabs. Notice there's a divides between the top hits and search items. Notice there's a divider between the search items and the bottom section.
Notice the quick insert icon is available only for search suggestions.
Notice all URLs in suggestions don't have http://www., htps://www., www. as prefix and they don't have a trailing /.
Notice that if you turn off the autocompleteTabs from Feature Flag Inventory you don't see the Switch to tab suggestions.

UI changes

Divider dark node	Divider light mode

No top divider	Bottom divider

anikiki · 2024-10-08T11:01:10Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite

CrisBarreiro

Added a few comments, but works as expected! 🚀

CrisBarreiro · 2024-10-09T09:09:54Z

app/src/main/java/com/duckduckgo/app/autocomplete/api/AutoComplete.kt

-            .onErrorReturn { emptyList() }
-            .toObservable()
+        // TODO: ANA - Do we want to have this check here, or somewhere else? (note: this is using the RxComputationThreadPool).
+        if (autocompleteTabsFeature.self().isEnabled()) {


I think it's fine to keep it here, but I'm wondering whether we should cache the value, so we don't need to process the toggle every time. See HistoryFeature

I updated this in the last PR -> https://github.com/duckduckgo/Android/pull/5123/files#diff-e563a062fe06ca0a38b0c058df8314a24f2fffb40952a85a1e356be04697b58bR264

CrisBarreiro · 2024-10-09T09:11:18Z

app/src/main/java/com/duckduckgo/app/autocomplete/api/AutoComplete.kt

@@ -247,13 +249,18 @@ class AutoCompleteApi @Inject constructor(
    }

    private fun getAutocompleteSwitchToTabResults(query: String): Observable<MutableList<RankedSuggestion<AutoCompleteSwitchToTabSuggestion>>> =


nit: Can the return type have List instead of MutableList?

All MutableList were removed after moving away from rxJava -> #5123

CrisBarreiro · 2024-10-09T09:11:52Z

app/src/main/java/com/duckduckgo/app/autocomplete/api/AutoComplete.kt

+                .onErrorReturn { emptyList() }
+                .toObservable()
+        } else {
+            Observable.just(mutableListOf())


nit: Same here, can we just return listOf?

CrisBarreiro · 2024-10-09T09:15:25Z

app/src/test/java/com/duckduckgo/app/autocomplete/api/AutoCompleteApiTest.kt

Can you add a few tests here?

CrisBarreiro · 2024-10-09T09:20:33Z

app/src/main/java/com/duckduckgo/app/browser/autocomplete/SuggestionViewHolderFactory.kt

@@ -262,7 +260,7 @@ sealed class AutoCompleteViewHolder(itemView: View) : RecyclerView.ViewHolder(it
            editableSearchClickListener: (AutoCompleteSuggestion) -> Unit,
            omnibarPosition: OmnibarPosition,
        ) = with(binding) {
-            phrase.text = item.phrase
+            phrase.text = item.phrase.formatIfUrl()


Can we move this one level up so we don't need to format phrase for every type of element?

Done in the final PR -> #5123

Task/Issue URL: https://app.asana.com/0/1200581511062568/1208040472309277/f ### Description Removed rxjava from autosuggest. ### Steps to test this PR Smoke test the autosuggest. There should be no user facing changes. This is the final PR. See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f ### NO UI changes

anikiki mentioned this pull request Oct 8, 2024

Add translations for open tabs in search autosuggest #5065

Merged

4 tasks

anikiki marked this pull request as ready for review October 8, 2024 11:31

anikiki changed the title ~~Added feature flag.~~ Address the tasks in the Meta section Oct 8, 2024

anikiki added the STACKED PR - DO NOT MERGE label Oct 8, 2024

CrisBarreiro self-assigned this Oct 9, 2024

CrisBarreiro self-requested a review October 9, 2024 09:22

CrisBarreiro approved these changes Oct 9, 2024

View reviewed changes

anikiki mentioned this pull request Oct 10, 2024

Android: Migrate auto-complete to Flow and Coroutines #5123

Merged

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 1ee6d24 to 12256db Compare October 10, 2024 15:29

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from 418720f to cabd77b Compare October 10, 2024 15:29

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from c46cf24 to 5d0ed05 Compare October 10, 2024 15:39

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from cabd77b to 16012e8 Compare October 10, 2024 15:39

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 5d0ed05 to 871743c Compare October 10, 2024 15:45

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from 16012e8 to ed1fee2 Compare October 10, 2024 15:45

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from e62d927 to 26275f2 Compare October 11, 2024 16:07

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from ed1fee2 to f679db7 Compare October 11, 2024 16:07

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 26275f2 to 838a6b3 Compare October 18, 2024 12:10

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from 4b8c8a2 to e5b9a08 Compare October 18, 2024 12:10

anikiki added 5 commits October 21, 2024 16:14

Added feature flag.

41ff885

Removed unneeded quick insert items.

5c60b5d

Formatted urls in autosuggest.

efaeeae

Added dividers between sections. Updated color on switch to tab icon.

95c8473

Updated tests.

bb5d02d

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from e65d5a4 to f7a8db6 Compare October 21, 2024 15:15

anikiki force-pushed the feature/ana/address_the_tasks_in_the_meta_section branch from e5b9a08 to bb5d02d Compare October 21, 2024 15:15

This was referenced Oct 21, 2024

Bug: autocomplete pixels firing when Adding Bookmark #5165

Merged

Bug: Unable to delete autocomplete history items #5168

Merged

anikiki merged commit a62cc5a into feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n Oct 22, 2024
4 checks passed

anikiki deleted the feature/ana/address_the_tasks_in_the_meta_section branch October 22, 2024 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address the tasks in the Meta section #5105

Address the tasks in the Meta section #5105

anikiki commented Oct 8, 2024 •

edited by CrisBarreiro

Loading

anikiki commented Oct 8, 2024 •

edited

Loading

CrisBarreiro left a comment •

edited

Loading

CrisBarreiro Oct 9, 2024

anikiki Oct 14, 2024

CrisBarreiro Oct 9, 2024

anikiki Oct 14, 2024

CrisBarreiro Oct 9, 2024

CrisBarreiro Oct 9, 2024

anikiki Oct 14, 2024

CrisBarreiro Oct 9, 2024

anikiki Oct 14, 2024

		@@ -247,13 +249,18 @@ class AutoCompleteApi @Inject constructor(
		}

		private fun getAutocompleteSwitchToTabResults(query: String): Observable<MutableList<RankedSuggestion<AutoCompleteSwitchToTabSuggestion>>> =

Address the tasks in the Meta section #5105

Address the tasks in the Meta section #5105

Conversation

anikiki commented Oct 8, 2024 • edited by CrisBarreiro Loading

Description

Steps to test this PR

UI changes

anikiki commented Oct 8, 2024 • edited Loading

CrisBarreiro left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anikiki commented Oct 8, 2024 •

edited by CrisBarreiro

Loading

anikiki commented Oct 8, 2024 •

edited

Loading

CrisBarreiro left a comment •

edited

Loading