Handle clicks on "Switch to tab" #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
5 tasks
This was referenced Sep 25, 2024
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
1f569b5
to
212d405
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
3 times, most recently
from
ec962a9
to
21cda6f
Compare
|
Looks good and works as expected. I've noticed that if an open tab is also in history, then we won't switch to a new tab ut navigate instead, but I'm assuming that's expected and will be addressed later in the stack |
CrisBarreiro
approved these changes
Sep 26, 2024
6 tasks
There was a problem hiding this comment.
@anikiki I just realized that when clicking "Switch to tab" from the widget, we're opening a new tab instead. Can you please have a look?
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
c839039
to
bcbf0ae
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
21cda6f
to
39a2206
Compare
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
bcbf0ae
to
b64a8cf
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
39a2206
to
7210dda
Compare
Good catch @CrisBarreiro! Thanks 👍 I added a commit that fixes it. |
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
b64a8cf
to
b73f27f
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
7210dda
to
f929c92
Compare
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
b73f27f
to
941fff0
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
f929c92
to
322af6b
Compare
anikiki
force-pushed
the
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
branch
from
941fff0
to
d0da845
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
322af6b
to
bf286af
Compare
This was referenced Oct 21, 2024
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618748/f ### Description Updated the autosuggest algorithm to include open tabs. ### Steps to test this PR _Feature 1_ - [x] Install from this branch. - [x] Open a few tabs. - [x] Search for something matching an open tab. Notice open tabs are suggested if there is a match. - [x] Mark one of the open tabs as bookmark and don't close it. - [x] Search for something matching that bookmark. Notice that both the open tab and the bookmark are shown. ### NO UI changes --------- Co-authored-by: Dax The Translator <[email protected]>
anikiki
merged commit 192b423
into
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618742/f
Description
Handled tab switching.
Steps to test this PR
Feature 1
NO UI changes