-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle clicks on "Switch to tab" #5042
Handle clicks on "Switch to tab" #5042
Conversation
1f569b5
to
212d405
Compare
ec962a9
to
21cda6f
Compare
Looks good and works as expected. I've noticed that if an open tab is also in history, then we won't switch to a new tab ut navigate instead, but I'm assuming that's expected and will be addressed later in the stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anikiki I just realized that when clicking "Switch to tab" from the widget, we're opening a new tab instead. Can you please have a look?
c839039
to
bcbf0ae
Compare
21cda6f
to
39a2206
Compare
bcbf0ae
to
b64a8cf
Compare
39a2206
to
7210dda
Compare
Good catch @CrisBarreiro! Thanks 👍 I added a commit that fixes it. |
b64a8cf
to
b73f27f
Compare
7210dda
to
f929c92
Compare
b73f27f
to
941fff0
Compare
f929c92
to
322af6b
Compare
941fff0
to
d0da845
Compare
322af6b
to
bf286af
Compare
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618748/f ### Description Updated the autosuggest algorithm to include open tabs. ### Steps to test this PR _Feature 1_ - [x] Install from this branch. - [x] Open a few tabs. - [x] Search for something matching an open tab. Notice open tabs are suggested if there is a match. - [x] Mark one of the open tabs as bookmark and don't close it. - [x] Search for something matching that bookmark. Notice that both the open tab and the bookmark are shown. ### NO UI changes --------- Co-authored-by: Dax The Translator <[email protected]>
192b423
into
feature/ana/include_open_tabs_that_match_the_query_in_the_suggestions
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618742/f
Description
Handled tab switching.
Steps to test this PR
Feature 1
NO UI changes