Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels for open tabs in search autosuggest #5064

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Sep 25, 2024

Task/Issue URL: https://app.asana.com/0/1200581511062568/1208283215616231/f

Description

Added pixels.

Steps to test this PR

  • Install from this branch.
  • Filter logcat by m_autocomplete_click_switch_to_tab | m_autocomplete_displayed_switch_to_tab.
  • Navigate to https://www.wikipedia.org.
  • Open another tab.
  • Type `wiki.
  • Notice the first suggestion is the open tab.
  • Tap on the suggestion.
  • Notice in the logs (2 pixels sent with the correct params -> switch_to_tab_capable=true, showed_switch_to_tab=true):
    Pixel sent: m_autocomplete_displayed_switch_to_tab with params: {} {}
    Pixel sent: m_autocomplete_click_switch_to_tab with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=true} {}
  • Open another tab.
  • Type duck.
  • Tap on the first search suggestion. Notice nothing in the logs with the initial filter.
  • Filter logcat by showed_switch_to_tab.
  • Notice in the logs:
    Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=false} {}
  • Close all tabs.
  • Open a new tab and type duck.
  • Tap on the first search suggestion and notice in logs:
    Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=true, switch_to_tab_capable=false, showed_switch_to_tab=false} {}

NO UI changes

@anikiki anikiki changed the title Added pixels. Add pixels for open tabs in search autosuggest Sep 25, 2024
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 2a01940 to b7105cf Compare September 26, 2024 11:23
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 1ecf111 to 328e2b4 Compare September 26, 2024 11:23
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from b7105cf to 2ee8aac Compare September 26, 2024 11:45
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 328e2b4 to 2491fda Compare September 26, 2024 11:45
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 2ee8aac to bdf3526 Compare September 26, 2024 12:10
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 2491fda to e18e755 Compare September 26, 2024 12:10
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from bdf3526 to bdd704e Compare September 26, 2024 12:12
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from e18e755 to 6fbc6f3 Compare September 26, 2024 12:12
@anikiki anikiki marked this pull request as ready for review September 26, 2024 15:11
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from bdd704e to 72671a1 Compare October 10, 2024 15:29
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 6fbc6f3 to 880ec9e Compare October 10, 2024 15:29
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 72671a1 to e19f6c8 Compare October 10, 2024 15:39
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch 2 times, most recently from c2fd1de to 3abd869 Compare October 10, 2024 15:45
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 25144d4 to 673212b Compare October 11, 2024 16:07
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 3abd869 to e159b67 Compare October 11, 2024 16:07
Copy link
Contributor

@CrisBarreiro CrisBarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 673212b to 9ba4a97 Compare October 18, 2024 12:10
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from e159b67 to bc72676 Compare October 18, 2024 12:10
@anikiki anikiki force-pushed the feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place branch from 9ba4a97 to 24d6f50 Compare October 21, 2024 15:15
@anikiki anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from bc72676 to 82707b3 Compare October 21, 2024 15:15
Task/Issue URL:
https://app.asana.com/0/1200581511062568/1208400325419530/f

### Description
Translations.

### Steps to test this PR

- [x] Install from this branch.
- [x] Open a few tabs. E.g `www.gardenersworld.com`
- [x] Search for something that will match an open tab. E.g `garden`
- [x] Notice the "Switch to Tab · " text before the URL in the
suggestion.

### UI changes (Added Switch to Tab string)
| Before  | After |
| ------ | ----- |

|![switch_to_tab_before](https://github.com/user-attachments/assets/c2f2187d-7efe-4b2d-bc2f-31907c248726)|![switch_to_tab_after](https://github.com/user-attachments/assets/d0553336-b395-4576-a90d-58258d6f152b)|

---------

Co-authored-by: Dax The Translator <[email protected]>
@anikiki anikiki merged commit 8ca4f00 into feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place Oct 22, 2024
3 of 4 checks passed
@anikiki anikiki deleted the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch October 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants