-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels for open tabs in search autosuggest #5064
Merged
anikiki
merged 2 commits into
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
from
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
Oct 22, 2024
Merged
Add pixels for open tabs in search autosuggest #5064
anikiki
merged 2 commits into
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
from
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
This was referenced Sep 25, 2024
4 tasks
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
September 26, 2024 11:23
2a01940
to
b7105cf
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
September 26, 2024 11:23
1ecf111
to
328e2b4
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
September 26, 2024 11:45
b7105cf
to
2ee8aac
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
September 26, 2024 11:45
328e2b4
to
2491fda
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
September 26, 2024 12:10
2ee8aac
to
bdf3526
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
September 26, 2024 12:10
2491fda
to
e18e755
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
September 26, 2024 12:12
bdf3526
to
bdd704e
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
September 26, 2024 12:12
e18e755
to
6fbc6f3
Compare
This was referenced Oct 8, 2024
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
October 10, 2024 15:29
bdd704e
to
72671a1
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
October 10, 2024 15:29
6fbc6f3
to
880ec9e
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
October 10, 2024 15:39
72671a1
to
e19f6c8
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
2 times, most recently
from
October 10, 2024 15:45
c2fd1de
to
3abd869
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
October 11, 2024 16:07
25144d4
to
673212b
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
October 11, 2024 16:07
3abd869
to
e159b67
Compare
CrisBarreiro
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected! 🎉
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
October 18, 2024 12:10
673212b
to
9ba4a97
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
October 18, 2024 12:10
e159b67
to
bc72676
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
October 21, 2024 15:15
9ba4a97
to
24d6f50
Compare
anikiki
force-pushed
the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
from
October 21, 2024 15:15
bc72676
to
82707b3
Compare
This was referenced Oct 21, 2024
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208400325419530/f ### Description Translations. ### Steps to test this PR - [x] Install from this branch. - [x] Open a few tabs. E.g `www.gardenersworld.com` - [x] Search for something that will match an open tab. E.g `garden` - [x] Notice the "Switch to Tab · " text before the URL in the suggestion. ### UI changes (Added Switch to Tab string) | Before | After | | ------ | ----- | |![switch_to_tab_before](https://github.com/user-attachments/assets/c2f2187d-7efe-4b2d-bc2f-31907c248726)|![switch_to_tab_after](https://github.com/user-attachments/assets/d0553336-b395-4576-a90d-58258d6f152b)| --------- Co-authored-by: Dax The Translator <[email protected]>
anikiki
merged commit Oct 22, 2024
8ca4f00
into
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
3 of 4 checks passed
anikiki
deleted the
feature/ana/add_pixels_for_open_tabs_in_search_autosuggest
branch
October 22, 2024 11:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208283215616231/f
Description
Added pixels.
Steps to test this PR
m_autocomplete_click_switch_to_tab | m_autocomplete_displayed_switch_to_tab
.https://www.wikipedia.org
.switch_to_tab_capable=true
,showed_switch_to_tab=true
):Pixel sent: m_autocomplete_displayed_switch_to_tab with params: {} {}
Pixel sent: m_autocomplete_click_switch_to_tab with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=true} {}
duck
.showed_switch_to_tab
.Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=false} {}
duck
.Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=true, switch_to_tab_capable=false, showed_switch_to_tab=false} {}
NO UI changes