[Implementation] Android: Include existing open tabs in search autosuggest #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
anikiki
changed the title
This was referenced Sep 19, 2024
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
from
fc8300b
to
08c8e0d
Compare
This was referenced Oct 8, 2024
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
3 times, most recently
from
64aaecd
to
c8cd3d6
Compare
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
2 times, most recently
from
ba10a54
to
9e0586d
Compare
This was referenced Oct 21, 2024
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
from
4f005a7
to
4549790
Compare
Task/Issue URL: Added all open tabs to suggestions. All opened tabs (no checks on the query) are placed above history, for simplicity. Matching and ranking to be done separately. - [x] Install from this branch. - [x] Open a few websites in different tabs. - [x] Search for something and notice the "Tab" suggestions. There is no matching done, only check the UI (the switch to tab text is not yet present). | Example 1 (with history) | Example 2 (without history) | | ------ | ----- | ||| --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208264037618740 --------- Co-authored-by: Dax The Translator <[email protected]>
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
from
0808bd4
to
0856e20
Compare
Updated alignment.
anikiki
force-pushed
the
feature/ana/implementation_android_include_existing_open_tabs_in_search_autosuggest
branch
from
0856e20
to
b6243b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208260875798966/f
Description
The full implementation will span across a few tasks.
This is the main task for the implementation of Android: Include existing open tabs in search autosuggest
Steps to test this PR
See:
See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f