-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run on VM #142
Merged
Merged
Run on VM #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the prerequisite steps prior to running data prep
Everything works up through creating and connecting to VM
Add a helper script to mount Azure File Shares
Mounting an Azure File Share to a linux OS via SMB defaults to read/write access. The change to the mount script default to read-only with file permissions (`0555`) Update Docs accordingly.
Reflect actual Azure FIles structure
don't touch config in this PR.
This was referenced Feb 18, 2024
Closed
cjyetman
added a commit
that referenced
this pull request
Feb 23, 2024
Change from /outputs to /mnt/outputs, to match structure defined in #142 and #145 No associated issue. Co-authored-by: CJ Yetman <[email protected]>
cjyetman
approved these changes
Feb 24, 2024
This was referenced Feb 25, 2024
cjyetman
added a commit
that referenced
this pull request
Feb 26, 2024
Update local docker config to match changes made to [docker-compose.yml](https://github.com/RMI-PACTA/workflow.data.preparation/blob/main/docker-compose.yml) in #142 Also set `2022Q4` config to inherit the `docker` config again (removed in #145). @AlexAxthelm this should not affect the `2022Q4_azure` because `2022Q4` will inherit the `docker` config, but when `2022Q4_azure` inherits `2022Q4` it will overwrite those paths from the `docker` config with the expected paths. ``` r config::get(config = "docker")$factset_data_path #> [1] "/mnt/factset-extracted" config::get(config = "2022Q4")$factset_data_path #> [1] "/mnt/factset-extracted" config::get(config = "2022Q4_azure")$factset_data_path #> [1] "/mnt/factset-extracted/factset-pacta_timestamp-20221231T000000Z_pulled-20240217T134528Z" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions for setting up a VM (including RMI-specific instructions).
Includes some helper scripts to facilitate mounting Azure File Shares.