Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop vm #146

Closed
wants to merge 58 commits into from
Closed

Develop vm #146

wants to merge 58 commits into from

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Feb 18, 2024

Not intended for Merging

This PR tracks the status of the develop-vm branch, which combines:

Config Changes:

Docs & Deploy Scripts

Behavior Changes: PRs in this section should be reviewed and merged in approximately this order, since there are dependencies between them. Hopefully nothing is too controversial, but most of the behavior can be reverted back to independence is that's desired.

into a complete working whole, while allowing those branches to stay focused.

Additional changes:

Temporary updates to README to include directions for testing with this branch.

cjyetman and others added 29 commits February 15, 2024 10:53
Define the prerequisite steps prior to running data prep
Everything works up through creating and connecting to VM
Add a helper script to mount Azure File Shares
Mounting an Azure File Share to a linux OS via SMB defaults to
read/write access. The change to the mount script default to read-only
with file permissions (`0555`)

Update Docs accordingly.
Reflect actual Azure FIles structure
don't touch config in this PR.
@AlexAxthelm
Copy link
Collaborator Author

AlexAxthelm commented Feb 18, 2024

Tested as of 78f5c4a. Ran into an error exporting manifest.json

Note, memory consumption during 2022Q4 prep currently peaking at ~17GiB, though the process started with 700MiB consumed.

Start:

2024-02-18T03:59:41+0000
               total        used        free      shared  buff/cache   available
Mem:            31Gi       701Mi        24Gi       4.0Mi       6.0Gi        30Gi
Swap:             0B          0B          0B
               total        used        free      shared  buff/cache   available
Mem:        32804032      718000    25784184        4100     6301848    31599176
Swap:              0           0           0

Peak Consumption

2024-02-18T03:59:41+0000
               total        used        free      shared  buff/cache   available
Mem:            31Gi       701Mi        24Gi       4.0Mi       6.0Gi        30Gi
Swap:             0B          0B          0B
               total        used        free      shared  buff/cache   available
Mem:        32804032      718000    25784184        4100     6301848    31599176
Swap:              0           0           0

Comparing to the docker container logs, it looks like (as expected) equity_abcd_scenario_WEO2022 is the culprit (timezones don't match)

INFO [2024-02-18 04:15:46] Formatting and saving file: "equity_abcd_scenario_GECO2022.rds".
INFO [2024-02-18 04:39:59] Formatting and saving file: "equity_abcd_scenario_WEO2022.rds".
INFO [2024-02-18 05:32:05] Formatting and saving file: "equity_abcd_scenario_ISF2021.rds".

AlexAxthelm and others added 26 commits February 18, 2024 16:29
Create an input_filepaths object, rather than use individual filepaths
adjust code to account for changes made in #150
create a unique directory for outputs, and warn if it already exists

Closes: #151
Change from /outputs to /mnt/outputs, to match structure defined in #142 and #145

No associated issue.
Export a zip archive of all files specified as inputs and the contents of the output directory

Closes: #152
Use explicit filepath vectors for archive export process defined in #153
We may want to have a more elegant solution in the future (see
discussion in #138), but this works for now to include git status in the
manifest export.

Closes: #138
Establish a working draft of a 2023Q4 config that build sucessfully.

Closes: #144
Only change from 2022Q4 is data sources, in hope of getting a functional
build, while
RMI-PACTA/pacta.scenario.preparation#83
is in process.
@AlexAxthelm AlexAxthelm mentioned this pull request Feb 24, 2024
3 tasks
@AlexAxthelm
Copy link
Collaborator Author

Closing PR as superseded by #163

@AlexAxthelm AlexAxthelm deleted the develop-vm branch February 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants