-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deploy): Harmonize docker mount points #154
Conversation
Gonna take me some time to test this locally to make sure it works in the local Docker context. Some quick thoughts though...
default:
data_prep_outputs_path: ""
asset_impact_data_path: ""
factset_data_path: ""
2022Q4_azure:
inherits: 2022Q4
data_prep_outputs_path: "/mnt/outputs"
asset_impact_data_path: "/inputs"
factset_data_path: "/inputs"
2022Q4_docker:
inherits: 2022Q4
data_prep_outputs_path: "/outputs"
asset_impact_data_path: "/inputs"
factset_data_path: "/inputs"
2022Q4_desktop:
inherits: 2022Q4
data_prep_outputs_path: "/path/to/local/outputs"
asset_impact_data_path: "/path/to/local/inputs"
factset_data_path: "/path/to/local/inputs" |
prefer to wait until #161 merges and add this new context specific path to the new "docker" config instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, seems to work... still uncertain about the logic of outputs living under /mnt
but inputs not
This was compensating for the fact that I forgot to move the outputs directory in #145 |
Change from /outputs to /mnt/outputs, to match structure defined in #142 and #145
No associated issue.