Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update paths for local docker context #164

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

cjyetman
Copy link
Member

Update local docker config to match changes made to docker-compose.yml in #142

Also set 2022Q4 config to inherit the docker config again (removed in #145). @AlexAxthelm this should not affect the 2022Q4_azure because 2022Q4 will inherit the docker config, but when 2022Q4_azure inherits 2022Q4 it will overwrite those paths from the docker config with the expected paths.

config::get(config = "docker")$factset_data_path
#> [1] "/mnt/factset-extracted"
config::get(config = "2022Q4")$factset_data_path
#> [1] "/mnt/factset-extracted"
config::get(config = "2022Q4_azure")$factset_data_path
#> [1] "/mnt/factset-extracted/factset-pacta_timestamp-20221231T000000Z_pulled-20240217T134528Z"

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just a question, for running this locally/ in RStudio, would this now require that any relevant data lives at /mnt/asset-impact?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 26, 2024

Edit: nevermind, I just looked at the README.md and it sounds like the preferred approach for RStudio is to just edit the config.yml file itself whenever you want to run it.

Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjyetman cjyetman merged commit 3aec433 into main Feb 26, 2024
@cjyetman cjyetman deleted the update-local-docker-paths branch February 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants