Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SbDirectoryOpen and SbDirectoryClose APIs #2773

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

madhurajayaraman
Copy link
Contributor

b/302730696

Change-Id: Icdce23666554e47789a9109ea861f5533ced2bf2

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.73%. Comparing base (686e489) to head (4c026ac).
Report is 40 commits behind head on main.

Files Patch % Lines
starboard/shared/linux/dev_input/dev_input.cc 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   57.90%   58.73%   +0.83%     
==========================================
  Files        1780     1781       +1     
  Lines       85217    85280      +63     
==========================================
+ Hits        49347    50092     +745     
+ Misses      35870    35188     -682     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

starboard/android/shared/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/android/shared/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Show resolved Hide resolved
@madhurajayaraman madhurajayaraman force-pushed the directories branch 3 times, most recently from 51da995 to cac36f1 Compare June 11, 2024 16:55
@madhurajayaraman madhurajayaraman force-pushed the directories branch 3 times, most recently from 89ba141 to a9e81d1 Compare June 13, 2024 16:47
third_party/musl/src/starboard/dirent.c Outdated Show resolved Hide resolved
net/cert/test_root_certs_unittest.cc Outdated Show resolved Hide resolved
starboard/android/shared/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/android/shared/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/iso/impl/directory_get_next.h Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Show resolved Hide resolved
starboard/shared/win32/posix_emu/dirent.cc Outdated Show resolved Hide resolved
b/302730696

Change-Id: Icdce23666554e47789a9109ea861f5533ced2bf2
Change-Id: I339d92414abd8374958913945f9e31e20763d191
Change-Id: I2530e3c539d817786ef456bb0387552bce65454e
@madhurajayaraman madhurajayaraman marked this pull request as ready for review June 18, 2024 17:13
@madhurajayaraman madhurajayaraman requested a review from a team as a code owner June 18, 2024 17:13
@madhurajayaraman madhurajayaraman enabled auto-merge (squash) June 18, 2024 17:13
@madhurajayaraman madhurajayaraman dismissed gbournou’s stale review June 18, 2024 18:57

Changes have all been made.

@madhurajayaraman madhurajayaraman merged commit 511940e into youtube:main Jun 18, 2024
351 of 366 checks passed
kaidokert added a commit that referenced this pull request Jun 20, 2024
kaidokert added a commit that referenced this pull request Jun 20, 2024
Reverts #2773

May have broken several on-device tests and internal builds

b/302730696
kaidokert added a commit that referenced this pull request Jun 22, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
kaidokert added a commit that referenced this pull request Jun 22, 2024
Add missing ABI wrappers for readdir_r. The dirent struct size is
different on 64/32bit platforms.

Fixes broken Raspi-2 builds after #2773  and #3603

b/302730696
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
Add missing ABI wrappers for readdir_r. The dirent struct size is
different on 64/32bit platforms.

Fixes broken Raspi-2 builds after #2773  and #3603

b/302730696

(cherry picked from commit 506e5f4)
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
(cherry picked from commit c9cfaa8)
kaidokert added a commit that referenced this pull request Jun 24, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
(cherry picked from commit c9cfaa8)
kaidokert added a commit that referenced this pull request Jun 24, 2024
…bDirectoryClose APIs"" (#3655)

Refer to the original PR: #3603

Re-land #2773

Reverts #3599

b/302730696

Co-authored-by: Kaido Kert <[email protected]>
kaidokert added a commit that referenced this pull request Jun 24, 2024
Refer to the original PR: #3640

Add missing ABI wrappers for readdir_r. The dirent struct size is
different on 64/32bit platforms.

Fixes broken Raspi-2 builds after #2773  and #3603

b/302730696

Co-authored-by: Kaido Kert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants