Fix ABI wrapping for readdir() #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
force-pushed
the
readdir_abi
branch
3 times, most recently
from
64f95ea
to
4c1e0e3
Compare
Add missing ABI wrappers for readdir_r. The dirent struct size is different on 64/32bit platforms. b/302730696
gbournou
approved these changes
Jun 22, 2024
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.h
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
gbournou
reviewed
Jun 22, 2024
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.h
Outdated
Show resolved
Hide resolved
gbournou
approved these changes
Jun 22, 2024
starboard/shared/modular/starboard_layer_posix_directory_abi_wrappers.h
Outdated
Show resolved
Hide resolved
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
kaidokert
added a commit
that referenced
this pull request
Jun 24, 2024
Refer to the original PR: #3640 Add missing ABI wrappers for readdir_r. The dirent struct size is different on 64/32bit platforms. Fixes broken Raspi-2 builds after #2773 and #3603 b/302730696 Co-authored-by: Kaido Kert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing ABI wrappers for readdir_r. The dirent struct size is different on 64/32bit platforms.
Fixes broken Raspi-2 builds after #2773 and #3603
b/302730696