Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deprecate SbDirectoryOpen and SbDirectoryClose APIs" #3599

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

kaidokert
Copy link
Member

Reverts #2773

May have broken several on-device tests and internal builds

b/302730696

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Jun 20, 2024

Datadog Report

Branch report: revert-2773-directories
Commit report: 134becf
Test service: cobalt

✅ 0 Failed, 34485 Passed, 6 Skipped, 9m 26.85s Total Time

Copy link
Contributor

@johnxwork johnxwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the logs, it looks like some Android devices are having connectivity issues in the lab. If you do see the on-device test failures you saw turn green with this revert, let's revert.

@kaidokert kaidokert merged commit 2c8c8ed into main Jun 20, 2024
659 of 666 checks passed
@kaidokert kaidokert deleted the revert-2773-directories branch June 20, 2024 16:07
kaidokert added a commit that referenced this pull request Jun 20, 2024
kaidokert added a commit to kaidokert/cobalt that referenced this pull request Jun 21, 2024
kaidokert added a commit to kaidokert/cobalt that referenced this pull request Jun 21, 2024
kaidokert added a commit that referenced this pull request Jun 22, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
(cherry picked from commit c9cfaa8)
kaidokert added a commit that referenced this pull request Jun 24, 2024
…#3603)

Re-land #2773

Reverts #3599

b/302730696

---------

Co-authored-by: Madhura Jayaraman <[email protected]>
(cherry picked from commit c9cfaa8)
kaidokert added a commit that referenced this pull request Jun 24, 2024
…bDirectoryClose APIs"" (#3655)

Refer to the original PR: #3603

Re-land #2773

Reverts #3599

b/302730696

Co-authored-by: Kaido Kert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants