fix: Use LogicalParentOverride for PopupPanel everywhere #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
reviewed
Jul 11, 2023
MartinZikmund
force-pushed
the
dev/mazi/logicalparentoverride
branch
from
4964759
to
e89ab42
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
|
The build 137759 found UI Test snapshots differences: Details
|
MartinZikmund
force-pushed
the
dev/mazi/logicalparentoverride
branch
from
e89ab42
to
fbfbd05
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
Youssef1313
approved these changes
Sep 3, 2024
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
MartinZikmund
force-pushed
the
dev/mazi/logicalparentoverride
branch
from
fbfbd05
to
05365be
Compare
Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents
MartinZikmund
force-pushed
the
dev/mazi/logicalparentoverride
branch
from
05365be
to
9429e10
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
1 similar comment
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
|
The build 138673 found UI Test snapshots differences: Details
|
|
The build 138674 found UI Test snapshots differences: Details
|
|
@Mergifyio backport release/stable/5.4 |
✅ Backports have been created
|
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Sep 19, 2024
…5.4/pr-12860 fix: Use LogicalParentOverride for PopupPanel everywhere (backport #12860)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 4964759
This pull request refactors the logical parent logic for UI elements by moving it from
FrameworkElementtoDependencyObjectExtensions. This simplifies the code and improves cross-platform consistency.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):