-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use LogicalParentOverride for PopupPanel everywhere #12860
Conversation
4964759
to
e89ab42
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
The build 137759 found UI Test snapshots differences: Details
|
e89ab42
to
fbfbd05
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
fbfbd05
to
05365be
Compare
Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents
05365be
to
9429e10
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-12860/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
1 similar comment
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-12860/index.html |
The build 138673 found UI Test snapshots differences: Details
|
The build 138674 found UI Test snapshots differences: Details
|
@Mergifyio backport release/stable/5.4 |
✅ Backports have been created
|
…5.4/pr-12860 fix: Use LogicalParentOverride for PopupPanel everywhere (backport #12860)
Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 4964759
This pull request refactors the logical parent logic for UI elements by moving it from
FrameworkElement
toDependencyObjectExtensions
. This simplifies the code and improves cross-platform consistency.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):