Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use LogicalParentOverride for PopupPanel everywhere (backport #12860) #18242

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2024

Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 4964759

This pull request refactors the logical parent logic for UI elements by moving it from FrameworkElement to DependencyObjectExtensions. This simplifies the code and improves cross-platform consistency.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #12860 done by [Mergify](https://mergify.com).

Previously it was used only on WASM and Skia, but that caused odd issues, because routed events got propagated from Popups to the logical parents

(cherry picked from commit 784a589)
(cherry picked from commit 9429e10)
@jeromelaban jeromelaban merged commit 45e3f89 into release/stable/5.4 Sep 19, 2024
96 of 100 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.4/pr-12860 branch September 19, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants