Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Range Check 96 Builtin Files #372

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add Range Check 96 Builtin Files #372

merged 1 commit into from
Jan 29, 2025

Conversation

Gali-StarkWare
Copy link
Contributor

@Gali-StarkWare Gali-StarkWare commented Jan 20, 2025

This change is Reviewable

@Gali-StarkWare Gali-StarkWare self-assigned this Jan 20, 2025
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review January 20, 2025 13:27
Copy link
Contributor Author

Gali-StarkWare commented Jan 20, 2025

@Gali-StarkWare Gali-StarkWare force-pushed the gali/rc96 branch 2 times, most recently from 9c88028 to f7a08e8 Compare January 21, 2025 07:26
@Gali-StarkWare Gali-StarkWare requested a review from alon-f January 21, 2025 12:19
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/rc128 to gali/add_rc128_builtin January 21, 2025 13:13
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/add_rc128_builtin to graphite-base/372 January 27, 2025 14:30
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/372 to main January 27, 2025 15:34
@Gali-StarkWare Gali-StarkWare force-pushed the gali/rc96 branch 3 times, most recently from 464811d to ed67f37 Compare January 28, 2025 09:01
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please open a pr for RC6 and it's integration seperatly

Reviewed 1 of 4 files at r3.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/rc6 to graphite-base/372 January 29, 2025 07:50
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/372 to main January 29, 2025 07:50
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 1 of 2 files at r2, 1 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_96/prover.rs line 49 at r4 (raw file):

        assert_ne!(log_size, 0);
        Self {
            // TODO(Gali): Remove once air-infra pads to LOG_N_LANES.

is this auto gen?

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_96/prover.rs line 49 at r4 (raw file):

Previously, ohad-starkware (Ohad) wrote…

is this auto gen?

No

Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare merged commit dc37189 into main Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants