-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Range Check 96 Builtin Files #372
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e9d03fe
to
4540370
Compare
bd41f4d
to
ab983c3
Compare
4540370
to
4432a98
Compare
9c88028
to
f7a08e8
Compare
4432a98
to
755b942
Compare
f7a08e8
to
356d760
Compare
575e11c
to
e66d428
Compare
356d760
to
473f3b6
Compare
e66d428
to
8d22c27
Compare
473f3b6
to
4120dcd
Compare
8d22c27
to
e9b8976
Compare
4120dcd
to
33c6f6c
Compare
e9b8976
to
4a4ba6b
Compare
33c6f6c
to
0edf369
Compare
4a4ba6b
to
a418f08
Compare
0edf369
to
6ed8e4d
Compare
a418f08
to
b1541f3
Compare
6ed8e4d
to
2df651d
Compare
659c03c
to
8d77476
Compare
958aa7a
to
af04e84
Compare
8d77476
to
8c25544
Compare
af04e84
to
fafaa73
Compare
fafaa73
to
f62a2e7
Compare
8c25544
to
8369484
Compare
464811d
to
ed67f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open a pr for RC6 and it's integration seperatly
Reviewed 1 of 4 files at r3.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
ed67f37
to
bfeb750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)
b783b36
to
07a479b
Compare
bfeb750
to
a9df5b1
Compare
a9df5b1
to
f66408a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 1 of 2 files at r2, 1 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_96/prover.rs
line 49 at r4 (raw file):
assert_ne!(log_size, 0); Self { // TODO(Gali): Remove once air-infra pads to LOG_N_LANES.
is this auto gen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_96/prover.rs
line 49 at r4 (raw file):
Previously, ohad-starkware (Ohad) wrote…
is this auto gen?
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
f66408a
to
535f0b4
Compare
This change is