-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate RC96 Builtin #367
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4d9ea3d
to
c75cea9
Compare
413cf13
to
e595da7
Compare
c75cea9
to
c1d308c
Compare
e595da7
to
20afccf
Compare
c1d308c
to
575e11c
Compare
20afccf
to
70cb298
Compare
356d760
to
473f3b6
Compare
70cb298
to
37b1357
Compare
37b1357
to
fa495a0
Compare
473f3b6
to
4120dcd
Compare
fa495a0
to
9e21ac5
Compare
4120dcd
to
33c6f6c
Compare
9e21ac5
to
0bd2c7e
Compare
33c6f6c
to
0edf369
Compare
0bd2c7e
to
31558e2
Compare
0edf369
to
6ed8e4d
Compare
31558e2
to
fead268
Compare
6ed8e4d
to
2df651d
Compare
f54b83b
to
d30d483
Compare
2bcf5da
to
bb68bd0
Compare
d30d483
to
aac6292
Compare
move above 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs
line 76 at r4 (raw file):
BuiltinSegments::builtin_memory_cells_per_instance(BuiltinName::range_check96); assert!( ((range_check_bits_96.stop_ptr - range_check_bits_96.begin_addr) % rc96_builtin_cells_per_instance) == 0,
move to a variable
Code quote:
range_check_bits_96.stop_ptr - range_check_bits_96.begin_addr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs
line 77 at r2 (raw file):
Previously, ohad-starkware (Ohad) wrote…
move above 11
Fixed in different pr
stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs
line 76 at r4 (raw file):
Previously, ohad-starkware (Ohad) wrote…
move to a variable
Done.
bb68bd0
to
4c90551
Compare
aac6292
to
73d5cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r2, 6 of 7 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs
line 76 at r4 (raw file):
Previously, Gali-StarkWare wrote…
Done.
Can you resolve this?
4c90551
to
3bf8f7c
Compare
a6c3ae3
to
6668236
Compare
3bf8f7c
to
e0be7d7
Compare
6668236
to
399827c
Compare
e0be7d7
to
bd373b4
Compare
399827c
to
fd6c43f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r6, all commit messages.
Reviewable status: 3 of 8 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r2, 2 of 7 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)
fd6c43f
to
e1d01e8
Compare
bd373b4
to
d18c5bd
Compare
e1d01e8
to
ed0626e
Compare
This change is