Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RC96 Builtin #367

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Integrate RC96 Builtin #367

merged 1 commit into from
Jan 29, 2025

Conversation

Gali-StarkWare
Copy link
Contributor

@Gali-StarkWare Gali-StarkWare commented Jan 20, 2025

This change is Reviewable

Copy link
Contributor Author

Gali-StarkWare commented Jan 20, 2025

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/add_rc128_builtin to gali/rc96 January 21, 2025 13:13
@Gali-StarkWare Gali-StarkWare changed the title Add RC6 and RC96 Builtin Integrate RC6 and RC96 Builtin Jan 21, 2025
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review January 21, 2025 14:25
@Gali-StarkWare Gali-StarkWare self-assigned this Jan 21, 2025
@Gali-StarkWare Gali-StarkWare force-pushed the gali/add_rc96_builtin branch 2 times, most recently from f54b83b to d30d483 Compare January 28, 2025 15:33
@ohad-starkware
Copy link
Contributor

stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 77 at r2 (raw file):

    pub range_check7_2_5: range_check_7_2_5::Claim,
    pub range_check4_3: range_check_4_3::Claim,
    pub range_check_6: range_check_6::Claim,

move above 11

Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 76 at r4 (raw file):

                    BuiltinSegments::builtin_memory_cells_per_instance(BuiltinName::range_check96);
                    assert!(
                        ((range_check_bits_96.stop_ptr - range_check_bits_96.begin_addr) % rc96_builtin_cells_per_instance) == 0,

move to a variable

Code quote:

range_check_bits_96.stop_ptr - range_check_bits_96.begin_addr

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 77 at r2 (raw file):

Previously, ohad-starkware (Ohad) wrote…

move above 11

Fixed in different pr


stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 76 at r4 (raw file):

Previously, ohad-starkware (Ohad) wrote…

move to a variable

Done.

Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 8 files at r2, 6 of 7 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 76 at r4 (raw file):

Previously, Gali-StarkWare wrote…

Done.

Can you resolve this?

@Gali-StarkWare Gali-StarkWare force-pushed the gali/add_rc96_builtin branch 2 times, most recently from a6c3ae3 to 6668236 Compare January 29, 2025 13:46
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 7 files at r6, all commit messages.
Reviewable status: 3 of 8 files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r2, 2 of 7 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/integrate_rc6 to graphite-base/367 January 29, 2025 16:36
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/367 to main January 29, 2025 16:37
@Gali-StarkWare Gali-StarkWare merged commit 09d76f7 into main Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants