Add Range Check 128 Builtin Files

[Gali-StarkWare]

This change is 

[Gali-StarkWare]

• Bitwise Builtin Files #381
• Integrate RC96 Builtin #367
• Add Range Check 96 Builtin Files #372
• Integrate Range Check 128 Builtin #357
• Add Range Check 128 Builtin Files #371 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alon-f]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

[shaharsamocha7]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson and @Gali-StarkWare)

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 46 at r1 (raw file):

}
impl ClaimGenerator {
    pub fn new(n_rows: usize, range_check_builtin_segment_start: u32) -> Self {

Let's assert here the n_rows is a power of 2

Code quote:

pub fn new(n_rows: usize, range_check_builtin_segment_start: u32) -> Self {

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 211 at r1 (raw file):

            #[allow(clippy::needless_range_loop)]
            for i in 0..N_LANES {
                if bit_reverse_index(

We are in the case that all the rows are not padded and thus this if will always pass
Can you remove?

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 269 at r1 (raw file):

                logup_gen.finalize_at([(1 << log_size) - 1, self.n_rows - 1]);
            (trace, total_sum, Some((claimed_sum, self.n_rows - 1)))
        };

replace

Suggestion:

let (trace, claimed_sum) = logup_gen.finalize_last();

[shaharsamocha7]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @andrewmilson and @Gali-StarkWare)

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/component.rs line 28 at r1 (raw file):

#[derive(Copy, Clone, Serialize, Deserialize, CairoSerialize)]
pub struct Claim {
    pub n_rows: usize,

Consider to change this to log_size

Suggestion:

    pub log_size: usize,

[Gali-StarkWare]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/component.rs line 28 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Consider to change this to log_size

Done.

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 46 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Let's assert here the n_rows is a power of 2

Changed to log_size

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 211 at r1 (raw file):

Previously, shaharsamocha7 wrote…

We are in the case that all the rows are not padded and thus this if will always pass
Can you remove?

Done.

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 269 at r1 (raw file):

Previously, shaharsamocha7 wrote…

replace

Done.

[shaharsamocha7]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

[Gali-StarkWare]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/components/range_check_builtin_bits_128/prover.rs line 62 at r3 (raw file):

        SimdBackend: BackendForChannel<MC>,
    {
        let log_size = self.log_size;

I see we don't always work with max(log_size, LOG_N_LANES), maybe I can initialise it with it (after checking that the received log_size != 0) and then we don't have to remember to apply it everywhere?

[shaharsamocha7]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

[shaharsamocha7]

Reviewed 1 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

[Gali-StarkWare]

Merge activity

• Jan 27, 9:29 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Jan 27, 9:29 AM EST: A user merged this pull request with Graphite.