Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize poly folding #162

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Optimize poly folding #162

merged 1 commit into from
Nov 19, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Nov 12, 2024

This change is Reviewable

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)


stwo_cairo_verifier/src/poly/line.cairo line 259 at r1 (raw file):

            .subline_evals {
                let x_inv = domain_initials_inv.pop_front().unwrap();
                let f_at_x = *eval.values[0];

can you use pop_front?

Code quote:

  let f_at_x = *eval.values[0];

stwo_cairo_verifier/src/poly/circle.cairo line 182 at r1 (raw file):

            .subcircle_evals {
                let y_inv = domain_initial_ys_inv.pop_front().unwrap();
                let f_at_p = *eval.bit_reversed_values[0];

Can you use pop_front?

Code quote:

*eval.bit_reversed_values[0]

@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch 2 times, most recently from 6f8f9bf to 4bce875 Compare November 13, 2024 21:25
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from ac1c800 to 8382a48 Compare November 13, 2024 21:35
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)


stwo_cairo_verifier/src/poly/circle.cairo line 182 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Can you use pop_front?

Done.


stwo_cairo_verifier/src/poly/line.cairo line 259 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

can you use pop_front?

Done.

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/src/poly/circle.cairo line 182 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Done.

nice

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @shaharsamocha7)

@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch from 4bce875 to a58d998 Compare November 14, 2024 14:15
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from 8382a48 to ad2ddbb Compare November 14, 2024 14:15
@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch from a58d998 to a74d6cd Compare November 14, 2024 18:43
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from ad2ddbb to 43e841c Compare November 14, 2024 18:43
@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch from a74d6cd to 45c1e13 Compare November 17, 2024 16:19
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from 43e841c to 9e9dce3 Compare November 17, 2024 16:19
@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch from 45c1e13 to 729aacf Compare November 17, 2024 18:09
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from 9e9dce3 to 2481cdf Compare November 17, 2024 18:10
@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch 2 times, most recently from 44331ce to f29ed97 Compare November 19, 2024 15:44
@andrewmilson andrewmilson force-pushed the 10-24-Implement_batch_inverse_on_M31_CM31 branch from f29ed97 to 643b60a Compare November 19, 2024 15:47
Base automatically changed from 10-24-Implement_batch_inverse_on_M31_CM31 to main November 19, 2024 15:51
@andrewmilson andrewmilson force-pushed the 11-12-Optimize_poly_folding branch from 2481cdf to 66cddea Compare November 19, 2024 15:56
@andrewmilson andrewmilson merged commit de9c86b into main Nov 19, 2024
5 checks passed
@andrewmilson andrewmilson deleted the 11-12-Optimize_poly_folding branch November 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants