-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize poly folding #162
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
stwo_cairo_verifier/src/poly/line.cairo
line 259 at r1 (raw file):
.subline_evals { let x_inv = domain_initials_inv.pop_front().unwrap(); let f_at_x = *eval.values[0];
can you use pop_front?
Code quote:
let f_at_x = *eval.values[0];
stwo_cairo_verifier/src/poly/circle.cairo
line 182 at r1 (raw file):
.subcircle_evals { let y_inv = domain_initial_ys_inv.pop_front().unwrap(); let f_at_p = *eval.bit_reversed_values[0];
Can you use pop_front?
Code quote:
*eval.bit_reversed_values[0]
6f8f9bf
to
4bce875
Compare
ac1c800
to
8382a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
stwo_cairo_verifier/src/poly/circle.cairo
line 182 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Can you use pop_front?
Done.
stwo_cairo_verifier/src/poly/line.cairo
line 259 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
can you use pop_front?
Done.
Previously, andrewmilson (Andrew Milson) wrote…
nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @shaharsamocha7)
4bce875
to
a58d998
Compare
8382a48
to
ad2ddbb
Compare
a58d998
to
a74d6cd
Compare
ad2ddbb
to
43e841c
Compare
a74d6cd
to
45c1e13
Compare
43e841c
to
9e9dce3
Compare
45c1e13
to
729aacf
Compare
9e9dce3
to
2481cdf
Compare
44331ce
to
f29ed97
Compare
f29ed97
to
643b60a
Compare
2481cdf
to
66cddea
Compare
This change is