Implement batch_inverse on M31,CM31 #137
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
2 times, most recently
from
88b78cd to
b3d6d74
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
8f80f3b to
879c0ba
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
b3d6d74 to
f015e1a
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
879c0ba to
e8e2b31
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
f015e1a to
7a97fdb
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
2 times, most recently
from
82903f4 to
5307458
Compare
andrewmilson
requested review from
ilyalesokhin-starkware and
shaharsamocha7
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
943c4da to
b70127f
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
4bce875 to
a58d998
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
b70127f to
9c29983
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
a58d998 to
a74d6cd
Compare
There was a problem hiding this comment.
I'm just not sure weather it's worth the effort to add libfunc or modify the proof because the batch inverses only account for ~3% of the total step count in the verification benchmarks I ran. WDYT?
Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
There was a problem hiding this comment.
Though maybe I'm overestimating the effort to add a libfunc or modify the proof.
Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
9c29983 to
aab4ad6
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
a74d6cd to
45c1e13
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
aab4ad6 to
eec00b8
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
45c1e13 to
729aacf
Compare
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
eec00b8 to
fa29a42
Compare
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
2 times, most recently
from
44331ce to
f29ed97
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
stwo_cairo_verifier/src/fields.cairo line 8 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
I'd reserve
Fieldfor something else.
Done.
stwo_cairo_verifier/src/fields.cairo line 18 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
I reported this one, but in the future, please report formatting errors in #compiler-dev.
Done. tyty
stwo_cairo_verifier/src/fields.cairo line 25 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
use pop_back
Done.
stwo_cairo_verifier/src/fields.cairo line 28 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
while let Some(value) = values_span.pop_back()
Done.
There was a problem hiding this comment.
Reviewed 7 of 8 files at r4.
Reviewable status: 6 of 9 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
andrewmilson
force-pushed
the
10-24-Implement_batch_inverse_on_M31_CM31
branch
from
f29ed97 to
643b60a
Compare
This change is