Optimize Coset::at #135
Merged
Optimize Coset::at #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
Merged
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 24, 2024
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
9623734 to
38b73f4
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
89d64a7 to
78c5c2b
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
38b73f4 to
940580e
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
78c5c2b to
b5d0fb6
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
940580e to
72c02f8
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
b5d0fb6 to
bb86b10
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
72c02f8 to
79a0f90
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
bb86b10 to
efee637
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
79a0f90 to
47b090e
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
efee637 to
eb20e33
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
47b090e to
166b918
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
eb20e33 to
ff194a5
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
166b918 to
9cc2ecb
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
ff194a5 to
3743c23
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
9cc2ecb to
50fa500
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
3743c23 to
c48e2b3
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
f015e1a to
7a97fdb
Compare
This was referenced Nov 12, 2024
Merged
Merged
ilyalesokhin-starkware
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 1 of 3 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti and @shaharsamocha7)
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
2 times, most recently
from
34037c3 to
0cbece3
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
2 times, most recently
from
020bb0c to
943c4da
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
0cbece3 to
08bd476
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
943c4da to
b70127f
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
08bd476 to
57faddc
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
b70127f to
9c29983
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
57faddc to
ec8bb38
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
9c29983 to
aab4ad6
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
ec8bb38 to
123f2cb
Compare
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
aab4ad6 to
eec00b8
Compare
andrewmilson
force-pushed
the
10-23-Refactor_FriVerifier_decommit_inner_layers
branch
from
123f2cb to
0a83d2a
Compare
Base automatically changed from
10-23-Refactor_FriVerifier_decommit_inner_layers
to
main
November 19, 2024 14:39
andrewmilson
force-pushed
the
10-23-Optimize_Coset_at
branch
from
eec00b8 to
fa29a42
Compare
This was referenced Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
Coset::at()since it accounted for 50% of steps for a verification. New approach reduces to 4%.This change is