Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed the step feature in delete #977

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

Doraemon012
Copy link
Contributor

Description

  • This PR fixes the issue of Inconsistent Data Removal.
  • Now, as a step is deleted in the frontend, it gets deleted in Firebase too.

Related Issue

Motivation and Context

It removes the problem of inconsistent data removal when a step is deleted. I've changed the functionality to delete a step, now the data is deleted from frontent as well as backend.

Screenshots or GIF (In case of UI changes):

issue_2023-12-14.05-10-13.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ABHISHEK-PANDEY2
Copy link
Collaborator

@Doraemon012 why does the page goes blank after you delete a step? could it be fixed ?

@Doraemon012
Copy link
Contributor Author

@ABHISHEK-PANDEY2

Final output :

CodelabzFix.webm

@shivareddy6 shivareddy6 merged commit 3b0952c into scorelab:master Jan 6, 2024
2 of 3 checks passed
@manzil-infinity180
Copy link

@ABHISHEK-PANDEY2 @shivareddy6 @Doraemon012 [This issue yet not FIXED] lets explain, this issue is not fixed totally the problem in which is this when we delete the second step the whole page is reloaded and become blank but this effect does not occurred when we delete the other step (when count of steps is greater then 2)

But steps is greater than 2 (>2) then it work fines

Demonstration what i said :
here is some video (the branch is up to date )

when only 2 steps

Screen.Recording.2024-01-11.at.11.12.22.PM.mov

when more than 2 steps

Screen.Recording.2024-01-11.at.11.14.22.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Data Removal - Remove Step Feature
4 participants