Changed the functionality to delete a step #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ABHISHEK-PANDEY2 Please review this Pull Request. |
|
Can you provide a video showing the functionality |
|
@shivareddy6 Sorry for the delay. I've opened a new PR for this issue #977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Pull Request I have changed the functionality to delete a step. Previously the code was adding the attribute
deleted:truein the firestore, but now it deletes the whole step.Related Issue
This PR solves the issue #905
Motivation and Context
This change is required so that there is less load of data on the firestore.
How Has This Been Tested?
As told in the CONTIBUTING.md file, I have tested the code and there is no issue.
Screenshots or GIF (In case of UI changes):
Types of changes
Checklist: