Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Data Removal - Remove Step Feature #905

Closed
perminder-17 opened this issue Oct 17, 2023 · 6 comments · Fixed by #977
Closed

Inconsistent Data Removal - Remove Step Feature #905

perminder-17 opened this issue Oct 17, 2023 · 6 comments · Fixed by #977
Labels
bug Something isn't working Feature New feature firebase

Comments

@perminder-17
Copy link

Describe the bug
The "Remove Step" feature currently exhibits inconsistent behavior, which affects the integrity of the application's data management. This inconsistency arises from the fact that, while it removes the step from the frontend, it merely marks the step as "deleted" in the backend (Firebase) by setting a deleted flag to true. When a user initiates the "Remove Step" action, a modal dialog warns them that this action cannot be undone. However, the current implementation contradicts this by retaining a soft-deleted copy of the step in the backend.

Expected behavior
To align the application's behavior with user expectations and best practices, it is recommended that the "Remove Step" feature should not only remove the step from the frontend but also delete it entirely from the backend. This ensures that the data remains consistent and adheres to the principle of data minimization. It will also reduce data storage and enhance the data consistency and alignment with user expectations.

Screenshots

issue3.webm
@github-actions github-actions bot added bug Something isn't working Feature New feature firebase labels Oct 17, 2023
@perminder-17
Copy link
Author

Hi @shivareddy6 and @ABHISHEK-PANDEY2 @Sarfraz-droid I have done working on it. If u see this as an issue I can make the PR.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 17, 2023
@shivareddy6
Copy link
Collaborator

Hi @shivareddy6 and @ABHISHEK-PANDEY2 @Sarfraz-droid I have done working on it. If u see this as an issue I can make the PR.

Sure, sounds like an issue to me

@perminder-17
Copy link
Author

Hi @shivareddy6 and @ABHISHEK-PANDEY2 @Sarfraz-droid I have done working on it. If u see this as an issue I can make the PR.

Sure, sounds like an issue to me

Okay, I am going to make a pr then

@Doraemon012
Copy link
Contributor

Doraemon012 commented Dec 13, 2023

@shivareddy6 I've opened a PR for this issue, please take a look.

@shivareddy6
Copy link
Collaborator

solved with #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feature New feature firebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants