Fix fetching of controllerChart from rancher store #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordojordo
force-pushed
the
2.8-install
branch
from
221f9a4 to
18f8363
Compare
|
I tired it, works fine |
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: kubewarden/kubewarden-controller#465 (comment)
This fixes an issue with Rancher
2.8.0-rc1where the Installation page was unable to find the kubewarden-controller chart even when the repository that contains the chart can be found. This issue was introduced by rancher/dashboard#9806 - which applied new properties to thecatalog/chartgetter.Originally to obtain a chart this method did not require a repo name and repo type, now if a
repoNameandrepoTypeare not passed along with thechartNameit will return nothing. This caused the controller chart to never be found, I have since added a method to retrieve the repo name and type, but ultimately this should be fixed on the dashboard side.This same behavior was also found when searching for the kubewarden-defaults chart, thus causing the installation banner to not display correctly.
rc1-install.mp4