Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "App upgrade notification shown for incorrect app (#9806)" #9958

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 20, 2023

Summary

Fixes #9957

Occurred changes and/or fixed issues

Areas or cases that should be tested

As per description the Edit/Upgrade link and Upgradable column. @jordojordo will need to be consulted once this merges as well, but it shouldn't break his change

Areas which could experience regressions

#9613 will need to be re-opened once this merges

@richard-cox richard-cox added this to the v2.8.0 milestone Oct 20, 2023
@richard-cox richard-cox requested a review from cnotv October 20, 2023 14:21
@richard-cox richard-cox self-assigned this Oct 20, 2023
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: I'm approving as a matter of release block, although we should test also reverted commits to ensure correct outcome, so we can be easily review the issue.

@richard-cox richard-cox merged commit 769cad7 into rancher:master Oct 20, 2023
9 checks passed
@richard-cox richard-cox deleted the fix-app-chart-matching branch October 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit/Upgradeing a Helm App fails to find the associated chart
2 participants