App upgrade notification shown for incorrect app #9613
Comments
|
I think this is a bug with generally how we connect installed applications and helm repo charts. There's no direct link between these two other than names (different source repo, different namespaces, etc). So keeping this out of the Edit: Name, also version matches |
richard-cox
changed the title
|
This is happening with all extensions and charts, not just Epinio. |
|
@gaktive @richard-cox it is not written in this issue how to reproduce it with other charts and I cannot reproduce following the steps. Any hint? |
|
For the original bug
If there's issues bringing up that system feel free to reach out to Tomas, he may be able to provide you access to his. Failing that, it might be tricky. I think you need to get two helm charts that contain the same app version and name |
|
I may rather mock the data where the function is used at this point, since anyway we have to write the test. |
|
@richard-cox I get |
|
Error is weird though, what does it mean?
|
|
The error means a pre-req for the chart is missing, in this case it's cert manager (https://docs.epinio.io/installation/install_epinio#cert-manager). However.... depending on how you installed rancher it should be there already. So this one would take a bit of debugging / investigation to solve. Tomas might be able to help there, though he will have scripts / the process to bring up the env pretty quickly |
|
Seems like the issue is related to the fact that we have 3 different names for "epinio" (versions are for this case):
We also usually retrieve information from the annotations to define the ID (it's made of 3 parts) :
Are these information supposed to be always there @richard-cox? Should we rather avoid to check updates if the values are not available? |
|
As mentioned in the discussion today, we should also check if the issue is extended to the Chart installation/edit. |
|
As there's no parameter to match cases with malformed data, these cases will just not display available updates. Another issue is related on how to compare |
|
@richard-cox |
|
Due to lack of tests, documentations, comments, interface and data of any type we'll create a test for each case mentioned in #9958 for the views:
Existing provided tests will be also reviewed due mentioned issues to have been already at least partially included: |
|
Moving to 2.10.0 since we're getting close to feature complete for 2.9.0 and this feels like it can be merged after. However, if this is in a branch, that makes this less risky to merge. |
|
Oh, this has been already completed but needs rebase, review comments, etc. |
|
FWIW, this issue affected a Longhorn upgrade. The original install was done using Helm, but the upgrade was accidentally done via UI. The net-effect was that persistent storage on our cluster crashed, we had to completely uninstall longhorn, re-install, and restore volumes from backup. The inconsistency in install/upgrade methods was a mistake on our part, but it had a very outsized impact on a cluster considering there weren't any guards/warnings along the journey through in the UI. So in my opinion it raises the importance of this issue and I thought I'd mention it. The UI JourneyThe Rancher UI offers an upgrade
Only Rancher-catalog chart versions are presented during version selection. This is also the case after adding the Longhorn-project repository to Apps > Repositories.
More information about what went wrongThe root-cause of the Longhorn crash is that the Rancher-catalog uses two charts to separate out CRDs and resources (longhorn-crds + longhorn), while the Longhorn-project uses a single chart that includes CRDs and resources. The Rancher chart does offer some protections by checking for CRDs during template rendering. However, this protection only works on fresh installs and not for upgrades -- Helm will very happily see that the CRDs do in fact exist, finish the render process, then proceed to perform the upgrade which involves uninstalling things that don't exist in the new chart, the CRDs. Upgrade Log |
|
There's a PR that should address this issue but has been left hanging due to priorities on other tech debts: #10180 |
No problem :) |
|
Closing in favour of #11465, it's newer but contains more update to date repo instructions, SURE links and path forward |
Setup
Describe the bug
When Epinio Extension is installed it offers a wrong update
102.0.3+up1.8.1which belongs to a different App - official Epinio Rancher App (not an extension but app).To Reproduce
localcluster ->Apps->Installed Appsand filter outcattle-ui-plugin-systemnamespaceResult
Note the update "version tag" which belongs to different app (Epinio App).
Expected Result
It should recognize only updates for the extension.
The text was updated successfully, but these errors were encountered: