Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App upgrade uses wrong repository when same name chart is available in multiple repos #10209

Open
abhi1693 opened this issue Sep 5, 2021 · 33 comments
Labels
Milestone

Comments

@abhi1693
Copy link

abhi1693 commented Sep 5, 2021

Rancher Server Setup

  • Rancher version: 2.6.0
  • Installation option (Docker install/Helm Chart): Helm Chart
    • If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1
  • Proxy/Cert Details: No proxy, Cloudflare certificate

Information about the Cluster

  • Kubernetes version: v1.20.4
  • Cluster Type (Local/Downstream): Downstream
    • If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): vSphere

Describe the bug

I deployed minio today using the UI and I wanted to change the configuration, and the app started giving undefined annotations errors. I then realised from the developer options network tab that the UI is trying to fetch the chart from the wrong repo. The version that was deployed was not available in the other repo and so now I cannot upgrade the app.

To Reproduce

  1. Add https://charts.bitnami.com/bitnami and https://helm.min.io/ to the chart repos
  2. Using the chart in the minio repo, deploy the minion app with default settings
  3. Try to upgrade, the UI will throw errors in YAML even if no changes are made

Result
The UI does not let me upgrade the app

Expected Result

The chart should use the repo via which it was deployed instead of using the first repo it finds itself in

Screenshots

Additional context

@abhi1693
Copy link
Author

This issue exists with v2.5.10 as well using Cluster Explorer

@stale
Copy link

stale bot commented Dec 28, 2021

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Dec 28, 2021
@abhi1693
Copy link
Author

It's still relevant

@stale stale bot removed the status/stale label Dec 28, 2021
@stale
Copy link

stale bot commented Feb 27, 2022

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Feb 27, 2022
@abhi1693
Copy link
Author

It's still relevant

@stale stale bot removed the status/stale label Feb 27, 2022
@abhi1693
Copy link
Author

The issue exists in v2.5.11 as well

@stale
Copy link

stale bot commented Apr 28, 2022

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Apr 28, 2022
@abhi1693
Copy link
Author

Still relevant

@stale stale bot removed the status/stale label Apr 28, 2022
@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

Still relevant

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

Still relevant

@ikogan
Copy link

ikogan commented Aug 30, 2022

Still very relevant. This includes both helm charts that are local (not installed from any repository) as well as remote. It's now impossible to upgrade several apps in my clusters as they are present in more than one helm repo.

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

Relevant

@ikogan
Copy link

ikogan commented Oct 29, 2022

Very relevant

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

abhi1693 commented Jul 2, 2023

Relevant even after 2 years

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@ikogan
Copy link

ikogan commented Sep 2, 2023

Relevant. I'm not sure exactly why some helm charts show up and others don't. A way to simply ignore them would be nice.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

abhi1693 commented Nov 3, 2023

@khushboo-rancher sorry to tag you but could this be looked at because after 2+ years, it's still an issue even in the latest versions.

@ikogan
Copy link

ikogan commented Nov 3, 2023

Yup, still relevant. Thanks @abhi1693!

Copy link
Contributor

github-actions bot commented Jan 3, 2024

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@abhi1693
Copy link
Author

abhi1693 commented Jan 3, 2024

@khushboo-rancher Sorry to tag you, but can this be fixed? Been waiting for the team to see this for 2 years now.

@rancher-max @anupama2501 @richard-cox @nicholasSUSE @slickwarren @jiaqiluo

@richard-cox richard-cox transferred this issue from rancher/rancher Jan 3, 2024
@richard-cox
Copy link
Member

@abhi1693 i've transferred the issue to the repo responsible for UI.

Would you be able to expand on UI will throw errors in YAML? what is the error and where is it?

We have the ability at the moment to manually select the repo and chart if the chart for the app cannot be found. For a quick fix i think we should ..

  • Make it clearer which repo, chart and version will be installed when the user clicks update on an existing app
  • Allow the user to override / change the repo, chart and version which the UI finds
    This would be a nice 'catch all' scenario which covers other issues.

An expanded solution would be to record the helm repo url and chart name as an annotation on the helm app resource. The UI would then pick that by default when going to the update wizard.

@richard-cox richard-cox added this to the v2.8.x milestone Jan 3, 2024
@richard-cox
Copy link
Member

Linking an issue where we incorrectly connect an existing app with a chart repo - #9613

@richard-cox richard-cox modified the milestones: v2.8.x, v2.9.x Jan 19, 2024
@richard-cox richard-cox changed the title [2.6] App upgrade uses wrong repository when same name chart is available in multiple repos App upgrade uses wrong repository when same name chart is available in multiple repos Jan 19, 2024
@gaktive gaktive modified the milestones: v2.9.x, v2.12.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants