Add toolchain setup to all features test #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When splitting the workflows in c26ac6b, the all features test workflow was left without a step to setup the Rust toolchain. This has led to failures as the wrong toolchain can get used in some situations.
We were previously using `rustup default stable` for our stable rust workflows and `cargo +<toolchain>` for anything on nightly or oldstable. This patch switches to `cargo +<toolchain>` for everything (mostly for consistency)
andreaphylum
previously approved these changes
Aug 2, 2023
andreaphylum
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting the workflows in c26ac6b, the all features test workflow was left without a step to setup the Rust toolchain. This has led to failures as the wrong toolchain can get used in some situations (particularly on the self-hosted runner).