Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toolchain setup to all features test #1171

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Add toolchain setup to all features test #1171

merged 2 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. Add toolchain setup to all features test 

    When splitting the workflows in c26ac6b, the all features test workflow
was left without a step to setup the Rust toolchain. This has led to
failures as the wrong toolchain can get used in some situations.
    @kylewillmon
    kylewillmon committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7642cd1 View commit details
    Browse the repository at this point in the history

  2. Don't rely on setting default toolchain 

    We were previously using `rustup default stable` for our stable rust
workflows and `cargo +<toolchain>` for anything on nightly or oldstable.
This patch switches to `cargo +<toolchain>` for everything (mostly for
consistency)
    @kylewillmon
    kylewillmon committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ee61147 View commit details
    Browse the repository at this point in the history