Skip to content

Commit

Permalink
Don't rely on setting default toolchain
Browse files Browse the repository at this point in the history
We were previously using `rustup default stable` for our stable rust
workflows and `cargo +<toolchain>` for anything on nightly or oldstable.
This patch switches to `cargo +<toolchain>` for everything (mostly for
consistency)
  • Loading branch information
kylewillmon committed Aug 2, 2023
1 parent 7642cd1 commit ee61147
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,10 @@ jobs:
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

- name: Install Rust toolchain
run: |
rustup toolchain install --no-self-update stable --profile minimal -c clippy
rustup default stable
run: rustup toolchain install --no-self-update stable --profile minimal -c clippy

- name: Clippy
run: cargo clippy --locked --all-features --all-targets -- -D warnings
run: cargo +stable clippy --locked --all-features --all-targets -- -D warnings

test-matrix:
strategy:
Expand All @@ -56,12 +54,10 @@ jobs:
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

- name: Install Rust toolchain
run: |
rustup toolchain install --no-self-update stable --profile minimal
rustup default stable
run: rustup toolchain install --no-self-update stable --profile minimal

- name: Test
run: cargo test --locked
run: cargo +stable test --locked

oldstable:
strategy:
Expand Down Expand Up @@ -90,14 +86,12 @@ jobs:
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

- name: Install Rust toolchain
run: |
rustup toolchain install --no-self-update stable --profile minimal
rustup default stable
run: rustup toolchain install --no-self-update stable --profile minimal

- name: All Features
env:
PHYLUM_API_KEY: ${{ secrets.PHYLUM_TOKEN_STAGING }}
run: cargo test --all-features
run: cargo +stable test --all-features

deno-checks:
if: github.event_name != 'schedule'
Expand Down

0 comments on commit ee61147

Please sign in to comment.