Enhance per bucket, and per document monitor notification message ctx. #1450

AWSHurneyt · 2024-03-05T16:44:43Z

Issue #, if available:
#1300
#1396
#1401

Description of changes:

Added support for returning sample documents for bucket level monitors, and document level monitors.
Added support for printing query/rule info in notification messages for document level monitors.

CheckList:

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <[email protected]>

… document level monitors. Signed-off-by: AWSHurneyt <[email protected]>

eirsep · 2024-03-11T18:18:24Z

typically we create smaller PRs. one for each issue is a practice we should try follow

…t instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt · 2024-03-12T02:15:45Z

The nonsecurity-related test failures seem related to the fixes in PR #1464

The security-related test failures have been failing for some time, so they're unrelated to these changes.
https://github.com/opensearch-project/alerting/actions/workflows/security-test-workflow.yml?query=branch%3Amain

AWSHurneyt · 2024-03-12T02:17:15Z

typically we create smaller PRs. one for each issue is a practice we should try follow

@eirsep agreed. Would you say that's blocking for this PR? All of the changes will require the AlertContext class, so the second PR couldn't be raised until the first is merged.

…or sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]>

…r sample docs. Signed-off-by: AWSHurneyt <[email protected]>

eirsep

Skimmed through the PR. Need to take a deeper look to understand the top hits and low hits logic

alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt

eirsep · 2024-03-14T00:07:52Z

alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt

+
+        val searchResponse: SearchResponse = client.suspendUntil { client.search(searchRequest, it) }
+        val aggs = searchResponse.convertToMap().getOrDefault("aggregations", mapOf<String, Any>()) as Map<String, Any>
+        val compositeAgg = aggs.getOrDefault("composite_agg", mapOf<String, Any>()) as Map<String, Any>


Are all aggs of composite type??

The frontend visual editor translates the bucket monitor creation form selections into a composite aggregation (source); however, different aggregation types could potentially be configured using the extraction query editor.

As discussed offline, I'll take a follow-up item to support more than composite aggregations.

Created issue #1473 to track this follow-up item.

alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt

Signed-off-by: AWSHurneyt <[email protected]>

eirsep · 2024-03-14T17:36:12Z

alerting/src/main/kotlin/org/opensearch/alerting/script/BucketLevelTriggerExecutionContext.kt

 data class BucketLevelTriggerExecutionContext(
    override val monitor: Monitor,
    val trigger: BucketLevelTrigger,
    override val results: List<Map<String, Any>>,
    override val periodStart: Instant,
    override val periodEnd: Instant,
    val dedupedAlerts: List<Alert> = listOf(),
-    val newAlerts: List<Alert> = listOf(),
+    val newAlerts: List<AlertContext> = listOf(),


could have been a separate field to have alert context list and retain new alerts

I'll add this as a follow-up item.

eirsep · 2024-03-14T17:37:48Z

alerting/src/main/kotlin/org/opensearch/alerting/util/AlertingUtils.kt

+ *
+ * @return a [Set] of [String]s indicating fields within a document.
+ */
+fun parseSampleDocTags(messageTemplate: Script): Set<String> {


we should ideally have a parameter enrichContextWithSampleDocs in the create monitor request inside the trigger payload

Agreed. I'll create an issue to track updating the trigger data model to add this boolean-based logic.

Created issue #1475 to track this follow-up item.

eirsep · 2024-03-14T17:38:41Z

alerting/src/test/kotlin/org/opensearch/alerting/DocumentMonitorRunnerIT.kt

+        }
+    }
+
+    fun `test expected document and rules print in notification message`() {


can we add a test for scenario where there is error alert from the trigger evaluation

I'll add this as a follow-up item.

Create issue #1476 to track this follow-up item.

eirsep · 2024-03-14T17:42:43Z

alerting/src/test/kotlin/org/opensearch/alerting/MonitorRunnerServiceIT.kt

@@ -1989,6 +1990,88 @@ class MonitorRunnerServiceIT : AlertingRestTestCase() {
        }
    }

+    fun `test bucket-level monitor notification message includes sample docs per bucket`() {


plz add more test coverage . scenarios verifying each of the checks to printsSampleDocs

I'll add this as a follow-up item.

Create issue #1476 to track this follow-up item. For context, the printsSampleDocs function does have unit testing (link); but integration testing will increase confidence.

opensearch-trigger-bot · 2024-03-14T20:43:23Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1450-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5dc690caf1d4b9935f9aeb946c104be8d4861a77
# Push it to GitHub
git push --set-upstream origin backport-1450-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1450-to-2.x.

opensearch-project#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]>

…ion message ctx. (#1450) (#1477) * Enhance per bucket, and per document monitor notification message ctx. (#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]> * Fixed imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>

opensearch-trigger-bot · 2024-03-15T17:58:19Z

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.11
# Create a new branch
git switch --create backport-1450-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5dc690caf1d4b9935f9aeb946c104be8d4861a77
# Push it to GitHub
git push --set-upstream origin backport-1450-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-1450-to-2.11.

…ion message ctx. (opensearch-project#1450) (opensearch-project#1477) * Enhance per bucket, and per document monitor notification message ctx. (opensearch-project#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]> * Fixed imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt · 2024-03-15T18:29:03Z

alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt

+            val isTriggered = !nextAlerts[trigger.id]?.get(AlertCategory.NEW).isNullOrEmpty()
+            if (isTriggered && printsSampleDocData(trigger)) {
+                try {
+                    val searchRequest = monitorCtx.inputService!!.getSearchRequest(


This current implementation executes the monitor query multiple times; the first time on line 124 to collect the data for trigger evaluation, and then subsequent searches are executed for each triggered trigger in order to collect sample documents.

Ideally, we want to collect the sample documents in the call to collectInputResults on line 124 so we can avoid multiple queries as that will improve performance.

Created issue #1481 to track this follow-up item.

…ion message ctx. (opensearch-project#1450) (opensearch-project#1477) * Enhance per bucket, and per document monitor notification message ctx. (opensearch-project#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]> * Fixed imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>

…tion message ctx. (#1450) (#1480) * [Backport 2.x] Enhance per bucket, and per document monitor notification message ctx. (#1450) (#1477) * Enhance per bucket, and per document monitor notification message ctx. (#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]> * Fixed imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * [Backport 2.11] Backport #1427 and #1464 to 2.11 (#1479) * Feature findings enhancemnt (#1427) (#1457) * added support for param in Finding API * added detectionType as param for Findings API enhancements * added searchString param in FIndingsAPI * adding addiional params findingIds, startTime and endTime --------- (cherry picked from commit 2420c2c) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Findings API Enhancements changes and integ tests fix (#1464) (#1474) * solution to fix integ tests Signed-off-by: Riya Saxena <[email protected]> * fix flaky DocumentMonitor Runner tests Signed-off-by: Riya Saxena <[email protected]> * fix findings API enhancemnts Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit ba84d04) * fix integ tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joanne Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Riya <[email protected]> * [Backport 2.x] Enhance per bucket, and per document monitor notification message ctx. (#1450) (#1477) * Enhance per bucket, and per document monitor notification message ctx. (#1450) * Adding dev logs. Signed-off-by: AWSHurneyt <[email protected]> * Added support for returning sample documents for bucket level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing query/rule info in notification messages. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Extracted out helper function. Signed-off-by: AWSHurneyt <[email protected]> * Added support for printing document data in notification messages for document level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic after making AlertContext a separate class from Alert instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]> * Moved AlertContext data model from common utils to alerting plugin. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added additional unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Extracted sample doc aggs logic into helper function. Added support for sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]> * Extracted get sample doc logic into helper function. Added sorting for sample docs. Signed-off-by: AWSHurneyt <[email protected]> * Removed dev code. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Added comments based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Added logic to make mGet calls in batches. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5dc690c) Signed-off-by: AWSHurneyt <[email protected]> * Fixed imports. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Fixed test. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint error. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joanne Wang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Riya <[email protected]>

AWSHurneyt added the backport 2.x label Mar 5, 2024

AWSHurneyt requested review from lezzago, sbcd90, eirsep, getsaurabh02, praveensameneni, qreshi, bowenlan-amzn, rishabhmaurya, engechas and riysaxen-amzn as code owners March 5, 2024 16:44

AWSHurneyt changed the title ~~3.0 issue1401~~ Enhance per bucket, and per document monitor notification message ctx. Mar 5, 2024

AWSHurneyt added 6 commits March 11, 2024 00:15

Adding dev logs.

65f7f09

Signed-off-by: AWSHurneyt <[email protected]>

Added support for returning sample documents for bucket level monitors.

dc8431f

Signed-off-by: AWSHurneyt <[email protected]>

Added support for printing query/rule info in notification messages.

35a5264

Signed-off-by: AWSHurneyt <[email protected]>

Extracted out helper function.

2cf5667

Signed-off-by: AWSHurneyt <[email protected]>

Extracted out helper function.

60e3091

Signed-off-by: AWSHurneyt <[email protected]>

Added support for printing document data in notification messages for…

2d46922

… document level monitors. Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt force-pushed the 3.0-issue1401 branch from 063ed65 to 2d46922 Compare March 11, 2024 07:21

AWSHurneyt added 4 commits March 11, 2024 15:43

Refactored logic after making AlertContext a separate class from Aler…

8cb0168

…t instead of inheriting/extending it in common utils. Signed-off-by: AWSHurneyt <[email protected]>

Moved AlertContext data model from common utils to alerting plugin.

85cf9f1

Signed-off-by: AWSHurneyt <[email protected]>

Fixed ktlint errors.

e54acac

Signed-off-by: AWSHurneyt <[email protected]>

Added additional unit tests.

f3bea23

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt mentioned this pull request Mar 12, 2024

Enhance per bucket, and per document monitor notification message ctx. opensearch-project/common-utils#605

Closed

5 tasks

AWSHurneyt added 2 commits March 12, 2024 16:55

Extracted sample doc aggs logic into helper function. Added support f…

a1dc077

…or sorting sample docs based on metric aggregations. Signed-off-by: AWSHurneyt <[email protected]>

Extracted get sample doc logic into helper function. Added sorting fo…

b3c4f4b

…r sample docs. Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt requested a review from jowg-amazon as a code owner March 12, 2024 23:57

eirsep requested changes Mar 14, 2024

View reviewed changes

AWSHurneyt added 2 commits March 13, 2024 23:29

Added comments based on PR feedback.

235056c

Signed-off-by: AWSHurneyt <[email protected]>

Added logic to make mGet calls in batches.

e61e602

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt mentioned this pull request Mar 14, 2024

Support more aggregation types for per bucket monitor sample documents #1473

Closed

eirsep approved these changes Mar 14, 2024

View reviewed changes

This was referenced Mar 14, 2024

Refactor enhanced alert notification message context to a boolean option in the triggers #1475

Open

Increase test coverage for enhanced alert notification messages #1476

Closed

riysaxen-amzn approved these changes Mar 14, 2024

View reviewed changes

AWSHurneyt merged commit 5dc690c into opensearch-project:main Mar 14, 2024
15 of 18 checks passed

opensearch-trigger-bot bot added the failed backport label Mar 14, 2024

AWSHurneyt mentioned this pull request Mar 14, 2024

[Backport 2.x] Enhance per bucket, and per document monitor notification message ctx. (#1450) #1477

Merged

1 task

AWSHurneyt added the backport 2.11 label Mar 15, 2024

AWSHurneyt mentioned this pull request Mar 15, 2024

[Backport 2.11] Enhance per bucket, and per document monitor notification message ctx. (#1450) #1480

Merged

1 task

AWSHurneyt commented Mar 15, 2024

View reviewed changes

AWSHurneyt mentioned this pull request Mar 15, 2024

[Enhancement] Reduce number of query executions needed for enhanced alert notification message context #1481

Open

AWSHurneyt mentioned this pull request Mar 26, 2024

Support for fetching rule data in detector's trigger notification message in CTX variable opensearch-project/security-analytics#514

Closed

praveensameneni mentioned this pull request Mar 26, 2024

[FEATURE] deliver security alerts with meaningful, structured information. opensearch-project/security-analytics#625

Closed

AWSHurneyt mentioned this pull request Apr 3, 2024

Added documentation for printing associated queries, and sample documents in notification message. opensearch-project/documentation-website#6866

Merged

1 task

This was referenced Apr 3, 2024

[FEATURE] Add bucket level monitors metric values to the "ctx" object for notifications #1287

Open

[FEATURE] Show key string in monitor UI for per bucket monitor #1282

Closed

This was referenced Apr 12, 2024

[BUG] Opensearch Alerting: Per Document Monitor not including document field(s) in alert message #1281

Open

[BUG] Problem with getting ctx.results #479

Open

AWSHurneyt mentioned this pull request Apr 16, 2024

[FEATURE] Sample docs in notification message for deduped, and completedAlerts #1519

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance per bucket, and per document monitor notification message ctx. #1450

Enhance per bucket, and per document monitor notification message ctx. #1450

AWSHurneyt commented Mar 5, 2024 •

edited

Loading

eirsep commented Mar 11, 2024

AWSHurneyt commented Mar 12, 2024

AWSHurneyt commented Mar 12, 2024

eirsep left a comment

eirsep Mar 14, 2024

AWSHurneyt Mar 14, 2024

AWSHurneyt Mar 14, 2024

eirsep Mar 14, 2024

AWSHurneyt Mar 14, 2024

eirsep Mar 14, 2024

AWSHurneyt Mar 14, 2024

AWSHurneyt Mar 14, 2024 •

edited

Loading

eirsep Mar 14, 2024

AWSHurneyt Mar 14, 2024

AWSHurneyt Mar 14, 2024

eirsep Mar 14, 2024

AWSHurneyt Mar 14, 2024

AWSHurneyt Mar 14, 2024

opensearch-trigger-bot bot commented Mar 14, 2024

opensearch-trigger-bot bot commented Mar 15, 2024

AWSHurneyt Mar 15, 2024

AWSHurneyt Mar 15, 2024

Enhance per bucket, and per document monitor notification message ctx. #1450

Enhance per bucket, and per document monitor notification message ctx. #1450

Conversation

AWSHurneyt commented Mar 5, 2024 • edited Loading

eirsep commented Mar 11, 2024

AWSHurneyt commented Mar 12, 2024

AWSHurneyt commented Mar 12, 2024

eirsep left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AWSHurneyt Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Mar 14, 2024

opensearch-trigger-bot bot commented Mar 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AWSHurneyt commented Mar 5, 2024 •

edited

Loading

AWSHurneyt Mar 14, 2024 •

edited

Loading