Enhance per bucket, and per document monitor notification message ctx. #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
… level monitor notification messages. Added support for printing query/rule info in doc level monitor notification messages. Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
engechas and
riysaxen-amzn
as code owners
1 task
Signed-off-by: AWSHurneyt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=========================================
Coverage 73.95% 73.95%
- Complexity 896 901 +5
=========================================
Files 133 134 +1
Lines 5890 5910 +20
Branches 716 717 +1
=========================================
+ Hits 4356 4371 +15
- Misses 1222 1226 +4
- Partials 312 313 +1 ☔ View full report in Codecov by Sentry. |
src/main/kotlin/org/opensearch/commons/alerting/model/AlertContext.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
riysaxen-amzn
previously approved these changes
Mar 6, 2024
engechas
previously approved these changes
Mar 11, 2024
src/main/kotlin/org/opensearch/commons/alerting/model/AlertContext.kt
Outdated
Show resolved
Hide resolved
eirsep
requested changes
Mar 11, 2024
src/main/kotlin/org/opensearch/commons/alerting/model/AggregationResultBucket.kt
Show resolved
Hide resolved
…xtending it. Signed-off-by: AWSHurneyt <[email protected]>
engechas
approved these changes
Mar 11, 2024
eirsep
reviewed
Mar 11, 2024
eirsep
reviewed
Mar 11, 2024
src/test/kotlin/org/opensearch/commons/alerting/model/AlertContextTests.kt
Show resolved
Hide resolved
eirsep
reviewed
Mar 11, 2024
|
Closing this issue as I've moved these changes to the alerting plugin in PR opensearch-project/alerting#1450 based on this feedback #605 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accomplished this by adding the
AlertContextdata model, which we can use to store data we only want to expose via the notification messagectx. Storing sample documents, or query/rule lists in the alert document would bloat it; this data model allows us to separate the content of thectxfrom the content of theAlertdocuments.Issues Resolved
opensearch-project/alerting#1300
opensearch-project/alerting#1396
opensearch-project/alerting#1401
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.