Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce number of query executions needed for enhanced alert notification message context #1481

Open
AWSHurneyt opened this issue Mar 15, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@AWSHurneyt
Copy link
Collaborator

This current implementation executes the monitor query multiple times; the first time on line 124 to collect the data for trigger evaluation, and then subsequent searches are executed for each triggered trigger in order to collect sample documents.

Ideally, we want to collect the sample documents in the call to collectInputResults on line 124 so we can avoid multiple queries as that will improve performance.

Originally posted by @AWSHurneyt in #1450 (comment)

@AWSHurneyt AWSHurneyt changed the title Reduce number of query executions needed for enhanced alert notification message context [Enhancement] Reduce number of query executions needed for enhanced alert notification message context Apr 16, 2024
@AWSHurneyt AWSHurneyt added the enhancement New feature or request label Apr 16, 2024
@AWSHurneyt
Copy link
Collaborator Author

AWSHurneyt commented Apr 16, 2024

Reopening as this has not been implemented yet. This would improve the performance of the feature.

@dblock
Copy link
Member

dblock commented Jun 17, 2024

Catch All Triage - 1 2 3 4 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants