Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] migrate from deprecated addSpanProcessor to *TracerProvider constructor option #2645

Open
64 tasks
Tracked by #5344
pichlermarc opened this issue Jan 14, 2025 · 2 comments
Open
64 tasks
Tracked by #5344
Labels
type:feature-tracking A feature with sub-issues that need to be addressed

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Jan 14, 2025

Description

*TracerProvider#addSpanProcessor() is deprecated in favor of a constructor option and will be removed in SDK 2.0. To ensure a smoother transition for the contrib repo when we publish SDK 2.0, we should take care of this before we release 2.0 on February 17.

This issue is considered done when we have applied these changes in all packages of this repository

  • we moved from *TracerProvider#addSpanProcessor() to the constructor option
  • we made the necessary changes to the documentation

Packages checklist:

Note

For traigers/approvers/maintainers please link the appropriate PRs and update check boxes as we work through them. Some of these packages may not use this method anywhere. In that case, please simple mark them as done and add a comment "not used"

  • @opentelemetry/resource-detector-alibaba-cloud
  • @opentelemetry/instrumentation-user-interaction
  • @opentelemetry/resource-detector-container
  • @opentelemetry/instrumentation-generic-pool
  • @opentelemetry/instrumentation-document-load
  • @opentelemetry/resource-detector-instana
  • @opentelemetry/instrumentation-nestjs-core
  • @opentelemetry/resource-detector-github
  • @opentelemetry/instrumentation-aws-lambda
  • @opentelemetry/resource-detector-azure
  • @opentelemetry/instrumentation-cassandra-driver
  • @opentelemetry/instrumentation-memcached
  • @opentelemetry/instrumentation-long-task
  • @opentelemetry/resource-detector-aws
  • @opentelemetry/resource-detector-gcp
  • @opentelemetry/instrumentation-aws-sdk
  • @opentelemetry/instrumentation-connect
  • @opentelemetry/instrumentation-express
  • @opentelemetry/instrumentation-fastify
  • @opentelemetry/instrumentation-graphql
  • @opentelemetry/instrumentation-ioredis
  • @opentelemetry/instrumentation-mongodb
  • @opentelemetry/instrumentation-redis-4
  • @opentelemetry/instrumentation-restify
  • @opentelemetry/instrumentation-winston
  • @opentelemetry/instrumentation-bunyan
  • @opentelemetry/instrumentation-mysql2
  • @opentelemetry/instrumentation-router
  • @opentelemetry/instrumentation-mysql
  • @opentelemetry/instrumentation-redis
  • @opentelemetry/instrumentation-hapi
  • @opentelemetry/instrumentation-knex
  • @opentelemetry/instrumentation-pino
  • @opentelemetry/instrumentation-dns
  • @opentelemetry/instrumentation-koa
  • @opentelemetry/instrumentation-net
  • @opentelemetry/propagator-ot-trace
  • @opentelemetry/instrumentation-pg
  • @opentelemetry/id-generator-aws-xray
  • @opentelemetry/propagator-instana
  • @opentelemetry/auto-configuration-propagators
  • @opentelemetry/plugin-react-load
  • @opentelemetry/instrumentation-lru-memoizer
  • @opentelemetry/instrumentation-runtime-node
  • @opentelemetry/propagation-utils
  • @opentelemetry/auto-instrumentations-node
  • @opentelemetry/instrumentation-dataloader
  • @opentelemetry/auto-instrumentations-web
  • @opentelemetry/propagator-aws-xray-lambda
  • @opentelemetry/instrumentation-socket.io
  • @opentelemetry/instrumentation-cucumber
  • @opentelemetry/instrumentation-mongoose
  • @opentelemetry/instrumentation-amqplib
  • @opentelemetry/instrumentation-kafkajs
  • @opentelemetry/instrumentation-tedious
  • @opentelemetry/host-metrics
  • @opentelemetry/redis-common
  • @opentelemetry/instrumentation-undici
  • @opentelemetry/sql-common
  • @opentelemetry/contrib-test-utils
  • @opentelemetry/baggage-span-processor
  • @opentelemetry/propagator-aws-xray
  • @opentelemetry/instrumentation-fs
  • @opentelemetry/winston-transport
@pichlermarc pichlermarc added the type:feature-tracking A feature with sub-issues that need to be addressed label Jan 14, 2025
chancancode added a commit to tildeio/opentelemetry-js-contrib that referenced this issue Jan 16, 2025
This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the `examples` folder and there
are no changes to the published packages.

Ref open-telemetry#2645
chancancode added a commit to tildeio/opentelemetry-js-contrib that referenced this issue Jan 17, 2025
This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the README.md of each package,
other than that there are no runtime code changes.

Technically this is a user-facing change for users that previously
followed the examples.

Ref open-telemetry#2645
chancancode added a commit to tildeio/opentelemetry-js-contrib that referenced this issue Jan 17, 2025
This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates all usages **in tests** for each package, and
there are no changes to the runtime code.

Ref open-telemetry#2645
chancancode added a commit to tildeio/opentelemetry-js-contrib that referenced this issue Jan 17, 2025
This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates the runtime code in the test-utils package and
should be included in the package's CHANGELOG.

Ref open-telemetry#2645
@pichlermarc
Copy link
Member Author

Collectively, these PRs addresses all usages in this repository. After all of them are merged, this can be closed.

Awesome, thanks for working on this 🙂

chancancode added a commit to tildeio/opentelemetry-js-contrib that referenced this issue Jan 17, 2025
This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates all usages **in tests** for each package, and
there are no changes to the runtime code.

Ref open-telemetry#2645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature-tracking A feature with sub-issues that need to be addressed
Projects
None yet
Development

No branches or pull requests

2 participants