-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test-utils): Migrate away from deprecated addSpanProcessor
#2660
Conversation
This migrates from the deprecated `addSpanProcessor` method to the constructor option in preparation for the upcoming SDK 2.0 release. This commit migrates the runtime code in the test-utils package and should be included in the package's CHANGELOG. Ref open-telemetry#2645
I suppose these rules are to ping maintainers to look at any changes to the shared test utils, which is fair enough (though this is really minor). However, for the purpose of lerna-changelog, the pkg labels are definitely wrong. That should be fixed before merging. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 172 172
Lines 8137 8137
Branches 1649 1649
=======================================
Hits 7402 7402
Misses 735 735 |
addSpanProcessor
addSpanProcessor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks - I've changed the title to be refactor
this way it won't show up as a bugfix in the changelog.
The package lables won't affect the changelog - the entry generated will only be for |
@chancancode once you update the branch I'll proceed to merge it :) |
@david-luna pressed the button on the web UI, does that work for you? Let me know if you need a proper rebase |
This migrates from the deprecated
addSpanProcessor
method to the constructor option in preparation for the upcoming SDK 2.0 release.This commit migrates the runtime code in the test-utils package and should be included in the package's CHANGELOG.
Ref #2645 (cc @pichlermarc)