Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*): Migrate away from deprecated addSpanProcessor in README #2657

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

chancancode
Copy link
Contributor

This migrates from the deprecated addSpanProcessor method to the constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the README.md of each package, other than that there are no runtime code changes.

Technically this is a user-facing change for users that previously followed the examples, putting it in its own PR/commit so we can label it for learna-changelog if desired (probably a good idea, in case when it comes time to publishing, this ends up being the only change).

Ref #2645 (cc @pichlermarc)

This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the README.md of each package,
other than that there are no runtime code changes.

Technically this is a user-facing change for users that previously
followed the examples.

Ref open-telemetry#2645
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@david-luna david-luna changed the title doc(*): Migrate away from deprecated addSpanProcessor in README docs(*): Migrate away from deprecated addSpanProcessor in README Jan 17, 2025
@david-luna
Copy link
Contributor

@chancancode I've updated the PR title to pass the lint process. Thanks for your contribution :)

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (1dace2f) to head (035964a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         172      172           
  Lines        8137     8137           
  Branches     1649     1649           
=======================================
  Hits         7402     7402           
  Misses        735      735           

@chancancode
Copy link
Contributor Author

@david-luna updated the branch from the UI here, let me know if you need a proper rebase

@david-luna david-luna merged commit fed82d5 into open-telemetry:main Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.